public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] powerpc: Adapt gdsys 405ep boards to platform changes
Date: Thu, 26 Apr 2012 15:23:57 +0200	[thread overview]
Message-ID: <201204261523.57828.sr@denx.de> (raw)
In-Reply-To: <1335440976-20329-3-git-send-email-eibach@gdsys.de>

Hi Dirk,

On Thursday 26 April 2012 13:49:31 Dirk Eibach wrote:
> Print fpga info at last_stage_init on gdsys 405ep boards.
> Use dtt_init() to startup fans.

Your patchset is not organized optimally. You sent 8 patches in one patchset, 
from a quick glance 6 patches are ppc4xx related (4xx board changes), one is 
mpc85xx related and one is a general patch. I suggest that you move the ppc4xx 
patches into one patchset and exclude the other 2 patches from it and send 
them separately.

And please always put the responsible custodian on Cc.

I'll review the 4xx patches, once you resend them.

Thanks,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2012-04-26 13:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 11:49 [U-Boot] [PATCH 1/8] ppc4xx: Adjust environment size on neo Dirk Eibach
2012-04-26 11:49 ` [U-Boot] [PATCH 2/8] ppc4xx: Make gdsys 405ep boards reset more generic Dirk Eibach
2012-04-26 11:49 ` [U-Boot] [PATCH 3/8] powerpc: Adapt gdsys 405ep boards to platform changes Dirk Eibach
2012-04-26 13:23   ` Stefan Roese [this message]
2012-04-26 11:49 ` [U-Boot] [PATCH 4/8] powerpc: Support gdsys dlvision-10g hardware 1.20 Dirk Eibach
2012-04-26 11:49 ` [U-Boot] [PATCH 5/8] Consider CONFIG_ZERO_BOOTDELAY_CHECK when CONFIG_AUTOBOOT_KEYED is set Dirk Eibach
2012-04-26 11:49 ` [U-Boot] [PATCH 6/8] powerpc: Update gdsys board configurations Dirk Eibach
2012-04-26 11:49 ` [U-Boot] [PATCH 7/8] powerpc: Fix typo in gdsys_fpga.h Dirk Eibach
2012-04-26 11:49 ` [U-Boot] [PATCH 8/8] powerpc: Add sdcard and spi boot support to P1022DS Dirk Eibach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204261523.57828.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox