From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 26 Apr 2012 18:08:50 +0200 Subject: [U-Boot] [PATCH v2 2/6] powerpc/ppc4xx: Make gdsys 405ep boards reset more generic In-Reply-To: <1335448466-21051-3-git-send-email-eibach@gdsys.de> References: <1335448466-21051-1-git-send-email-eibach@gdsys.de> <1335448466-21051-3-git-send-email-eibach@gdsys.de> Message-ID: <201204261808.50686.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de HI Dirk, On Thursday 26 April 2012 15:54:22 Dirk Eibach wrote: > In order to add boards that have different hardware for fpga reset, > any 405ep gdsys board now provides these functions: > > void gd405ep_init(void); > void gd405ep_set_fpga_reset(unsigned state); > void gd405ep_setup_hw(void); > int gd405ep_get_fpga_done(unsigned fpga); One comment below: > diff --git a/include/gdsys_fpga.h b/include/gdsys_fpga.h > index 949864c..555fbe2 100644 > --- a/include/gdsys_fpga.h > +++ b/include/gdsys_fpga.h > @@ -58,6 +58,17 @@ typedef struct ihs_osd { > u16 y_pos; > } ihs_osd_t; > > +#ifdef CONFIG_NEO > +typedef struct ihs_fpga { > + u16 reflection_low; /* 0x0000 */ > + u16 versions; /* 0x0002 */ > + u16 fpga_features; /* 0x0004 */ > + u16 fpga_version; /* 0x0006 */ > + u16 reserved_0[8187]; /* 0x0008 */ > + u16 reflection_high; /* 0x3ffe */ > +} ihs_fpga_t; > +#endif checkpatch complains about typedef's. Please don't add more of them. I know that you already have some in your files. It would be great if you could clean this up with an follow-up patch, to remove all your local typedef's. Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de