public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c
Date: Sun, 29 Apr 2012 15:11:36 +0200	[thread overview]
Message-ID: <201204291511.36960.marex@denx.de> (raw)
In-Reply-To: <20120429121153.50DF8202B38@gemini.denx.de>

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1335652120-2646-1-git-send-email-marex@denx.de> you wrote:
> > cmd_nand.c: In function ?arg_off_size?:
> > cmd_nand.c:216:5: warning: ?maxsize? may be used uninitialized in this
> > function [-Wmaybe-uninitialized]
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Scott Wood <scottwood@freescale.com>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> > 
> >  common/cmd_nand.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Applied, thanks.
> 
> > NOTE: Why does this emit these blahs about UTF8? I just noticed git
> > started behaving weird on me, anyone can give me a hint how to disable
> > these?
> 
> Yes, I think I can: don't use funny characters like these quotes
> around "arg_off_size" and "maxsize" in the commit messages.

Looking closer at it, it's not standard "'" quote character, what the heck. But 
$LANG (and $LANGUAGE) is set to en_US.UTF8 . Damned, I'll try to find the root 
cause, but I feel like overcomplicated KDE4 combined with who-knows-what will 
win this battle :-/

> You will
> also notice that patchwork has problems with these, like here:
> 
> Traceback (most recent call last):
>   File "/home/wd/bin/pwclient", line 466, in <module>
>     main()
>   File "/home/wd/bin/pwclient", line 449, in main
>     action_apply(rpc, patch_id)
>   File "/home/wd/bin/pwclient", line 264, in action_apply
>     proc.communicate(s)
>   File "/usr/lib64/python2.7/subprocess.py", line 737, in communicate
>     self.stdin.write(input)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in
> position 450: ordinal not in range(128)
> 
> 
> 
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-29 13:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28 22:28 [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c Marek Vasut
2012-04-28 22:28 ` [U-Boot] [PATCH 2/2] GCC47: Fix warning in md5.c Marek Vasut
2012-04-28 23:24   ` Mike Frysinger
2012-04-29 12:11 ` [U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c Wolfgang Denk
2012-04-29 13:11   ` Marek Vasut [this message]
2012-04-29 18:08     ` Wolfgang Denk
2012-04-29 18:22       ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2012-04-28 22:24 Marek Vasut
2012-04-28 22:25 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204291511.36960.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox