public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/3] usb:udc:samsung Add functions for storing private gadget data in UDC driver
Date: Mon, 30 Apr 2012 01:25:12 +0200	[thread overview]
Message-ID: <201204300125.12972.marex@denx.de> (raw)
In-Reply-To: <1334762811-23068-4-git-send-email-l.majewski@samsung.com>

Dear Lukasz Majewski,

> This commit adds support for storing private data to Samsung's UDC
> driver. This data is afterward used by usb gadget.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>  drivers/usb/gadget/s3c_udc_otg.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c_udc_otg.c
> b/drivers/usb/gadget/s3c_udc_otg.c index f7f7b54..925d2f2 100644
> --- a/drivers/usb/gadget/s3c_udc_otg.c
> +++ b/drivers/usb/gadget/s3c_udc_otg.c
> @@ -133,6 +133,18 @@ static void nuke(struct s3c_ep *ep, int status);
>  static int s3c_udc_set_halt(struct usb_ep *_ep, int value);
>  static void s3c_udc_set_nak(struct s3c_ep *ep);
> 
> +void set_udc_gadget_private_data(void *p)
> +{
> +	DEBUG_SETUP("%s: the_controller: 0x%p, p: 0x%p\n", __func__,
> +	       the_controller, p);

debug() and fix this message, otherwise:

Acked-by: Marek Vasut <marex@denx.de>

Damn, I shouldn't have avoided reviewing them if I knew the remaining ones were 
so short. But after the first one, I was quite scared of what's coming next. 
Either way, here you go, fix these few issues and you're in mainline ;-)

> +	the_controller->gadget.dev.device_data = p;
> +}
> +
> +void *get_udc_gadget_private_data(struct usb_gadget *gadget)
> +{
> +	return gadget->dev.device_data;
> +}
> +
>  static struct usb_ep_ops s3c_ep_ops = {
>  	.enable = s3c_ep_enable,
>  	.disable = s3c_ep_disable,

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-29 23:25 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12  7:15 [U-Boot] [PATCH 0/4] usb:gadget:composite: Support for composite gadget framework Lukasz Majewski
2012-04-12  7:15 ` [U-Boot] [PATCH 1/4] usb:gadget:composite Composite framework - files from Linux kernel Lukasz Majewski
2012-04-14  9:46   ` Marek Vasut
2012-04-14 13:41   ` Wolfgang Denk
2012-04-14 13:42   ` Wolfgang Denk
2012-04-16  9:10     ` Lukasz Majewski
2012-04-16 13:59       ` Wolfgang Denk
2012-04-12  7:15 ` [U-Boot] [PATCH 2/4] usb:gadget:composite: Linux composite.{h/c} code adjustement for u-boot Lukasz Majewski
2012-04-14 13:46   ` Wolfgang Denk
2012-04-16  9:23     ` Lukasz Majewski
2012-04-16 14:01       ` Wolfgang Denk
2012-04-12  7:15 ` [U-Boot] [PATCH 3/4] usb:gadget: Wrapper for extracting usb_gadget from linux's device Lukasz Majewski
2012-04-14  9:47   ` Marek Vasut
2012-04-12  7:15 ` [U-Boot] [PATCH 4/4] usb:gadget: Extend device struct to device_data pointer Lukasz Majewski
2012-04-17  7:27 ` [U-Boot] [PATCH v2 0/3] usb:gadget:composite: Support for composite gadget framework Lukasz Majewski
2012-04-17  7:27   ` [U-Boot] [PATCH v2 1/3] usb:gadget:composite USB composite gadget support Lukasz Majewski
2012-04-17  7:47     ` Marek Vasut
2012-04-17 12:45       ` Lukasz Majewski
2012-04-17  7:27   ` [U-Boot] [PATCH v2 2/3] usb:gadget:composite: Support for composite at gadget.h Lukasz Majewski
2012-04-17  7:27   ` [U-Boot] [PATCH v2 3/3] usb:udc:samsung Add functions for storing private gadget data in UDC driver Lukasz Majewski
2012-04-17  7:59     ` Marek Vasut
2012-04-17 14:07 ` [U-Boot] [PATCH v3 0/3] usb:gadget:composite: Support for composite gadget framework Lukasz Majewski
2012-04-17 14:07   ` [U-Boot] [PATCH v3 1/3] usb:gadget:composite USB composite gadget support Lukasz Majewski
2012-04-17 15:32     ` Marek Vasut
2012-04-17 14:07   ` [U-Boot] [PATCH v3 2/3] usb:gadget:composite: Support for composite at gadget.h Lukasz Majewski
2012-04-17 14:07   ` [U-Boot] [PATCH v3 3/3] usb:udc:samsung Add functions for storing private gadget data in UDC driver Lukasz Majewski
2012-04-18 15:26 ` [U-Boot] [PATCH v4 0/3] usb:gadget:composite: Support for composite gadget framework Lukasz Majewski
2012-04-18 15:26   ` [U-Boot] [PATCH v4 1/3] usb:gadget:composite USB composite gadget support Lukasz Majewski
2012-04-25 22:53     ` Marek Vasut
2012-04-26  7:02       ` Lukasz Majewski
2012-04-29 23:22         ` Marek Vasut
2012-04-18 15:26   ` [U-Boot] [PATCH v4 2/3] usb:gadget:composite: Support for composite at gadget.h Lukasz Majewski
2012-04-29 23:23     ` Marek Vasut
2012-04-18 15:26   ` [U-Boot] [PATCH v4 3/3] usb:udc:samsung Add functions for storing private gadget data in UDC driver Lukasz Majewski
2012-04-29 23:25     ` Marek Vasut [this message]
2012-04-30  6:58       ` Lukasz Majewski
2012-04-30 12:31         ` Marek Vasut
2012-04-30 13:11           ` Lukasz Majewski
2012-04-30 13:38         ` Wolfgang Denk
2012-04-30 14:23           ` Lukasz Majewski
2012-04-30 14:51     ` [U-Boot] [PATCH v4 RESEND " Lukasz Majewski
2012-04-30 15:22       ` Marek Vasut
2012-04-30 15:23       ` Wolfgang Denk
2012-04-30 15:46         ` Lukasz Majewski
2012-04-25 15:53   ` [U-Boot] [PATCH v4 0/3] usb:gadget:composite: Support for composite gadget framework Lukasz Majewski
2012-04-25 17:06     ` Marek Vasut
2012-05-01 19:53 ` [U-Boot] [PATCH 0/4] " Marek Vasut
2012-05-02  7:10   ` Lukasz Majewski
2012-05-02 10:37     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204300125.12972.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox