From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Tue, 1 May 2012 23:11:07 +0200 Subject: [U-Boot] [PATCH V4] i.MX6: mx6q_sabrelite: add SATA bindings In-Reply-To: <4FA03F46.5010203@boundarydevices.com> References: <201205012125.59644.marex@denx.de> <4FA03F46.5010203@boundarydevices.com> Message-ID: <201205012311.07224.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Eric Nelson, > On 05/01/2012 12:25 PM, Marek Vasut wrote: > > Dear Eric Nelson, > > > >> Signed-off-by: Eric Nelson > >> --- > >> V2 has been stripped of the board-independent changes and > >> uses clrsetbits_le32() instead of twiddling bits by hand. > >> > >> V3 returns immediately from setup_sata() if enable_sata_clock() > >> returns an error. > >> > >> V4 removes extra #include and addresses a style issue as discussed > >> on the ML. > > > > It's still there ;-) > > > >> > >> > >> + |IOMUXC_GPR13_SATA_PHY_2_TX_1P104V > >> + |IOMUXC_GPR13_SATA_PHY_1_SLOW); > >> + > >> > >> + return 0 ;<---- here :-) > > My eyes are clearly not as finely tuned as yours... 1 dioptry on left eye, lazy-eye blindness on the right one ;-) > > What are the odd that I could tweak checkpatch.pl > without introducing another style issue? > That'd be awesome. > V5 forthcoming... Thanks :) Best regards, Marek Vasut