From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line.
Date: Wed, 2 May 2012 00:27:31 +0200 [thread overview]
Message-ID: <201205020027.31645.marex@denx.de> (raw)
In-Reply-To: <1335909976-25504-1-git-send-email-eric.nelson@boundarydevices.com>
Dear Eric Nelson,
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> tools/checkpatch.pl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 2048a44..0caffcb 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -3139,6 +3139,12 @@ sub process {
> "Statements terminations use 1 semicolon\n" .
$herecurr);
> }
>
> +# check for multiple semicolons
Are you sure about the comment ^ ;-)
> + if ($line =~ /\s+;$/) {
> + WARN("SPACEBEFORE_SEMICOLON",
> + "Blank before semicolon\n" . $herecurr);
> + }
> +
> # check for gcc specific __FUNCTION__
> if ($line =~ /__FUNCTION__/) {
> WARN("USE_FUNC",
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-01 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123551.html>
2012-05-01 22:06 ` [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line Eric Nelson
2012-05-01 22:27 ` Marek Vasut [this message]
2012-05-03 3:00 ` Mike Frysinger
2012-05-03 3:24 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205020027.31645.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox