* [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line.
[not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123551.html>
@ 2012-05-01 22:06 ` Eric Nelson
2012-05-01 22:27 ` Marek Vasut
2012-05-03 3:00 ` Mike Frysinger
0 siblings, 2 replies; 4+ messages in thread
From: Eric Nelson @ 2012-05-01 22:06 UTC (permalink / raw)
To: u-boot
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
tools/checkpatch.pl | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
index 2048a44..0caffcb 100755
--- a/tools/checkpatch.pl
+++ b/tools/checkpatch.pl
@@ -3139,6 +3139,12 @@ sub process {
"Statements terminations use 1 semicolon\n" . $herecurr);
}
+# check for multiple semicolons
+ if ($line =~ /\s+;$/) {
+ WARN("SPACEBEFORE_SEMICOLON",
+ "Blank before semicolon\n" . $herecurr);
+ }
+
# check for gcc specific __FUNCTION__
if ($line =~ /__FUNCTION__/) {
WARN("USE_FUNC",
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line.
2012-05-01 22:06 ` [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line Eric Nelson
@ 2012-05-01 22:27 ` Marek Vasut
2012-05-03 3:00 ` Mike Frysinger
1 sibling, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2012-05-01 22:27 UTC (permalink / raw)
To: u-boot
Dear Eric Nelson,
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> tools/checkpatch.pl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl
> index 2048a44..0caffcb 100755
> --- a/tools/checkpatch.pl
> +++ b/tools/checkpatch.pl
> @@ -3139,6 +3139,12 @@ sub process {
> "Statements terminations use 1 semicolon\n" .
$herecurr);
> }
>
> +# check for multiple semicolons
Are you sure about the comment ^ ;-)
> + if ($line =~ /\s+;$/) {
> + WARN("SPACEBEFORE_SEMICOLON",
> + "Blank before semicolon\n" . $herecurr);
> + }
> +
> # check for gcc specific __FUNCTION__
> if ($line =~ /__FUNCTION__/) {
> WARN("USE_FUNC",
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line.
2012-05-01 22:06 ` [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line Eric Nelson
2012-05-01 22:27 ` Marek Vasut
@ 2012-05-03 3:00 ` Mike Frysinger
2012-05-03 3:24 ` Eric Nelson
1 sibling, 1 reply; 4+ messages in thread
From: Mike Frysinger @ 2012-05-03 3:00 UTC (permalink / raw)
To: u-boot
On Tuesday 01 May 2012 18:06:16 Eric Nelson wrote:
> tools/checkpatch.pl | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
should be sent to lkml/kbuild lists ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120502/332dac01/attachment.pgp>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line.
2012-05-03 3:00 ` Mike Frysinger
@ 2012-05-03 3:24 ` Eric Nelson
0 siblings, 0 replies; 4+ messages in thread
From: Eric Nelson @ 2012-05-03 3:24 UTC (permalink / raw)
To: u-boot
On 05/02/2012 08:00 PM, Mike Frysinger wrote:
> On Tuesday 01 May 2012 18:06:16 Eric Nelson wrote:
>> tools/checkpatch.pl | 6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> should be sent to lkml/kbuild lists ...
> -mike
Thanks for the pointer Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-03 3:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <http://lists.denx.de/pipermail/u-boot/2012-May/123551.html>
2012-05-01 22:06 ` [U-Boot] [PATCH] checkpatch: warn of whitespace before semicolon at end of line Eric Nelson
2012-05-01 22:27 ` Marek Vasut
2012-05-03 3:00 ` Mike Frysinger
2012-05-03 3:24 ` Eric Nelson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox