public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MX5: PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH exchanged
Date: Wed, 9 May 2012 12:39:28 +0200	[thread overview]
Message-ID: <201205091239.28815.marek.vasut@gmail.com> (raw)
In-Reply-To: <20120509122921.4caffb54@archvile>

Dear David Jander,

> On Wed,  9 May 2012 12:13:04 +0200
> 
> Stefano Babic <sbabic@denx.de> wrote:
> > After an update to the MX51 reference manual (Rev. 5), the
> > values of the PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH
> > are now clearly wrong:
> > 
> > "Bit 13:
> > High / Low Output Voltage Range. This bit selects the output voltage mode
> > for SD2_CMD. 0 High output voltage mode
> > 1 Low output voltage mode"
> > 
> > The values are currently negated in code - fixed.
> > 
> > Reported-by: David Jander <david.jander@protonic.nl>
> > Signed-off-by: Stefano Babic <sbabic@denx.de>
> > CC: Marek Vasut <marek.vasut@gmail.com>
> > CC: David Jander <david.jander@protonic.nl>
> > ---
> > 
> >  arch/arm/include/asm/arch-mx5/iomux.h |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/include/asm/arch-mx5/iomux.h
> > b/arch/arm/include/asm/arch-mx5/iomux.h index 760371b..e3765a3 100644
> > --- a/arch/arm/include/asm/arch-mx5/iomux.h
> > +++ b/arch/arm/include/asm/arch-mx5/iomux.h
> > @@ -66,8 +66,8 @@ typedef enum iomux_pad_config {
> > 
> >  	PAD_CTL_HYS_ENABLE = 0x1 << 8,	/* Hysteresis enabled */
> >  	PAD_CTL_DDR_INPUT_CMOS = 0x0 << 9,/* DDR input CMOS */
> >  	PAD_CTL_DDR_INPUT_DDR = 0x1 << 9,/* DDR input DDR */
> > 
> > -	PAD_CTL_DRV_VOT_LOW = 0x0 << 13, /* Low voltage mode */
> > -	PAD_CTL_DRV_VOT_HIGH = 0x1 << 13,/* High voltage mode */
> > +	PAD_CTL_DRV_VOT_LOW = 0x1 << 13, /* Low voltage mode */
> > +	PAD_CTL_DRV_VOT_HIGH = 0x0 << 13,/* High voltage mode */
> > 
> >  } iomux_pad_config_t;
> >  
> >  /* various IOMUX input functions */
> 
> Acked!

Fine by me.

> 
> thanks.
> 
> Best regards,

Best regards,
Marek Vasut

      reply	other threads:[~2012-05-09 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-09 10:13 [U-Boot] [PATCH] MX5: PAD_CTL_DRV_VOT_LOW and PAD_CTL_DRV_VOT_HIGH exchanged Stefano Babic
2012-05-09 10:29 ` David Jander
2012-05-09 10:39   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205091239.28815.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox