From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 11 May 2012 21:25:27 +0200
Subject: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()
In-Reply-To: <1336671134-16342-4-git-send-email-michael@walle.cc>
References: <1336671134-16342-1-git-send-email-michael@walle.cc>
	<1336671134-16342-4-git-send-email-michael@walle.cc>
Message-ID: <20120511192527.6DF4020348D@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Michael Walle,

In message <1336671134-16342-4-git-send-email-michael@walle.cc> you wrote:
> Signed-off-by: Michael Walle <michael@walle.cc>

How many boards will be using this code?  

Eventually this should be made configurable?

> +	sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);

This should generate a warning: too many arguments for format.

Please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the pitiful, multipage, connection-boxed form to which  the  flow-
chart  has  today  been  elaborated, it has proved to be useless as a
design tool -- programmers draw flowcharts after, not before, writing
the programs they describe.                        - Fred Brooks, Jr.