public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Luka Perkov <uboot@lukaperkov.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kirkwood: add support for D-Link DNS-320
Date: Fri, 11 May 2012 22:10:14 +0200	[thread overview]
Message-ID: <20120511201014.GA862@w500.lan> (raw)
In-Reply-To: <op.wd34e8r34cuzmg@gonzo.lentin.co.uk>

On Fri, May 11, 2012 at 03:09:25PM +0100, Jamie Lentin wrote:
> >Are you sure you need this CONFIG_RESET_PHY_R at all? I mean I have the
> >same SoC and I do not need this at all. I think this part is left over
> >from other boards that we do not need anymore. It makes sense to remove
> >this if you do not need it on your board.
> >
> >Take a look here:
> >
> >http://git.denx.de/?p=u-boot/u-boot-arm.git;a=blob;f=board/raidsonic/ib62x0/ib62x0.c;h=65f2c2ea6a0415b0f508bc078528884e526dd201;hb=HEAD
> 
> I've fiddled for a while and cannot get a working Ethernet
> connection without this code to enable RGMII delay. Tried cloning
> configs/ib62x0.h, but no luck. Presumably you have the same PHY chip
> (88E1116R-NNC1) too?

I'm not sure... But if you really need this info I will disassemble the
box and take a look.

Anyway I'm glad you have double checked this.

> Agree that it's a copy and pasted chunk of code that shouldn't be
> there though and at least should find a common home somewhere.

Probably, but this is unrelated to this patch.

I have no more questions regarding this patch...

Regards,
Luka

      reply	other threads:[~2012-05-11 20:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 10:23 [U-Boot] [PATCH] kirkwood: add support for D-Link DNS-320 Jamie Lentin
2012-04-26 10:57 ` Prafulla Wadaskar
2012-04-26 14:00   ` Jamie Lentin
2012-05-01  9:25   ` [U-Boot] [PATCH 0/2] Generalise dns325 support and include dns320 Jamie Lentin
2012-05-01  9:25     ` [U-Boot] [PATCH 1/2] kirkwood: Rename dns325 to dnskw Jamie Lentin
2012-05-01  9:25     ` [U-Boot] [PATCH 2/2] kirkwood: Add support for the D-Link DNS-320 Jamie Lentin
2012-07-30 21:55     ` [U-Boot] [RESEND] [PATCH 0/2] kirkwood: Generalise dns325 support, include dns320 Jamie Lentin
2012-07-30 21:55       ` [U-Boot] [PATCH 1/2] kirkwood: Rename dns325 to dnskw Jamie Lentin
2012-07-30 21:55       ` [U-Boot] [PATCH 2/2] kirkwood: Add support for the D-Link DNS-320 Jamie Lentin
2012-07-31  5:56         ` Prafulla Wadaskar
2012-07-31  9:01           ` Jamie Lentin
2012-07-31 17:16             ` Stefan Herbrechtsmeier
2012-07-31  5:51       ` [U-Boot] [RESEND] [PATCH 0/2] kirkwood: Generalise dns325 support, include dns320 Prafulla Wadaskar
2012-07-31  8:31         ` Jamie Lentin
2012-07-31 10:35           ` Prafulla Wadaskar
2012-08-05 17:09             ` Jamie Lentin
2012-05-02 18:45 ` [U-Boot] [PATCH] kirkwood: add support for D-Link DNS-320 Luka Perkov
2012-05-11 14:09   ` Jamie Lentin
2012-05-11 20:10     ` Luka Perkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120511201014.GA862@w500.lan \
    --to=uboot@lukaperkov.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox