* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
@ 2012-05-12 16:07 Fabio Estevam
2012-05-12 16:10 ` Marek Vasut
2012-05-12 21:22 ` Wolfgang Denk
0 siblings, 2 replies; 9+ messages in thread
From: Fabio Estevam @ 2012-05-12 16:07 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
Scan only first 512 MB of DRAM to avoid memory wraparound.
This fixes mx28evk boot and it follows the same idea of commit
19a2066b57 (M28: Scan only first 512 MB of DRAM to avoid memory wraparound)
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx28evk.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 0c18e50..a4ea12d 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -75,7 +75,7 @@
*/
#define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */
#define PHYS_SDRAM_1 0x40000000 /* Base address */
-#define PHYS_SDRAM_1_SIZE 0x40000000 /* Max 1 GB RAM */
+#define PHYS_SDRAM_1_SIZE 0x20000000 /* Max 512MB RAM */
#define CONFIG_STACKSIZE (128 * 1024) /* 128 KB stack */
#define CONFIG_SYS_MALLOC_LEN 0x00400000 /* 4 MB for malloc */
#define CONFIG_SYS_MEMTEST_START 0x40000000 /* Memtest start adr */
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:07 [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound Fabio Estevam
@ 2012-05-12 16:10 ` Marek Vasut
2012-05-12 16:14 ` Fabio Estevam
2012-05-12 21:22 ` Wolfgang Denk
1 sibling, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2012-05-12 16:10 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Scan only first 512 MB of DRAM to avoid memory wraparound.
>
> This fixes mx28evk boot and it follows the same idea of commit
> 19a2066b57 (M28: Scan only first 512 MB of DRAM to avoid memory wraparound)
Thanks, sorry for the breakage.
Acked-by: Marek Vasut <marex@denx.de>
btw. I think Otavio was working on some common config, wasn't he?
btw2. won't there ever be MX28EVK with more than 512MB of DRAM?
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> include/configs/mx28evk.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
> index 0c18e50..a4ea12d 100644
> --- a/include/configs/mx28evk.h
> +++ b/include/configs/mx28evk.h
> @@ -75,7 +75,7 @@
> */
> #define CONFIG_NR_DRAM_BANKS 1 /* 1 bank of DRAM */
> #define PHYS_SDRAM_1 0x40000000 /* Base address */
> -#define PHYS_SDRAM_1_SIZE 0x40000000 /* Max 1 GB RAM */
> +#define PHYS_SDRAM_1_SIZE 0x20000000 /* Max 512MB RAM */
> #define CONFIG_STACKSIZE (128 * 1024) /* 128 KB stack */
> #define CONFIG_SYS_MALLOC_LEN 0x00400000 /* 4 MB for
malloc */
> #define CONFIG_SYS_MEMTEST_START 0x40000000 /* Memtest start adr */
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:10 ` Marek Vasut
@ 2012-05-12 16:14 ` Fabio Estevam
2012-05-12 16:19 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Fabio Estevam @ 2012-05-12 16:14 UTC (permalink / raw)
To: u-boot
On Sat, May 12, 2012 at 1:10 PM, Marek Vasut <marex@denx.de> wrote:
> Thanks, sorry for the breakage.
>
> Acked-by: Marek Vasut <marex@denx.de>
>
> btw. I think Otavio was working on some common config, wasn't he?
Yes, I think Otavio is working on that.
> btw2. won't there ever be MX28EVK with more than 512MB of DRAM?
I don't think there will be other revision of mx28evk board.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:14 ` Fabio Estevam
@ 2012-05-12 16:19 ` Marek Vasut
2012-05-12 16:40 ` Fabio Estevam
2012-05-12 16:51 ` Fabio Estevam
0 siblings, 2 replies; 9+ messages in thread
From: Marek Vasut @ 2012-05-12 16:19 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> On Sat, May 12, 2012 at 1:10 PM, Marek Vasut <marex@denx.de> wrote:
> > Thanks, sorry for the breakage.
> >
> > Acked-by: Marek Vasut <marex@denx.de>
> >
> > btw. I think Otavio was working on some common config, wasn't he?
>
> Yes, I think Otavio is working on that.
That'd be so cool ... :)
>
> > btw2. won't there ever be MX28EVK with more than 512MB of DRAM?
>
> I don't think there will be other revision of mx28evk board.
All right, this approach is valid then. Btw. Fabio, can you verify that you
don't see any memory aliasing now (just to avoid trouble).
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:19 ` Marek Vasut
@ 2012-05-12 16:40 ` Fabio Estevam
2012-05-12 17:06 ` Marek Vasut
2012-05-12 16:51 ` Fabio Estevam
1 sibling, 1 reply; 9+ messages in thread
From: Fabio Estevam @ 2012-05-12 16:40 UTC (permalink / raw)
To: u-boot
On Sat, May 12, 2012 at 1:19 PM, Marek Vasut <marex@denx.de> wrote:
> All right, this approach is valid then. Btw. Fabio, can you verify that you
> don't see any memory aliasing now (just to avoid trouble).
How can I verify this, please?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:40 ` Fabio Estevam
@ 2012-05-12 17:06 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2012-05-12 17:06 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> On Sat, May 12, 2012 at 1:19 PM, Marek Vasut <marex@denx.de> wrote:
> > All right, this approach is valid then. Btw. Fabio, can you verify that
> > you don't see any memory aliasing now (just to avoid trouble).
>
> How can I verify this, please?
Try writing some pattern into DRAM at "offset-sizeof(pattern area)" and try
reading it from "2*offset + sizeof(pattern area)" ... try doing the same for
4*offset etc.
You might also be able to read data from memory behind what uboot considers as
detected DRAM which will have the same contents as the detected DRAM etc.
>
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:19 ` Marek Vasut
2012-05-12 16:40 ` Fabio Estevam
@ 2012-05-12 16:51 ` Fabio Estevam
2012-05-12 17:07 ` Marek Vasut
1 sibling, 1 reply; 9+ messages in thread
From: Fabio Estevam @ 2012-05-12 16:51 UTC (permalink / raw)
To: u-boot
On Sat, May 12, 2012 at 1:19 PM, Marek Vasut <marex@denx.de> wrote:
> All right, this approach is valid then. Btw. Fabio, can you verify that you
> don't see any memory aliasing now (just to avoid trouble).
Actually I think it would be better to define the total size of RAM
for mx28evk as 128MB.
Do you agree?
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:51 ` Fabio Estevam
@ 2012-05-12 17:07 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2012-05-12 17:07 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
> On Sat, May 12, 2012 at 1:19 PM, Marek Vasut <marex@denx.de> wrote:
> > All right, this approach is valid then. Btw. Fabio, can you verify that
> > you don't see any memory aliasing now (just to avoid trouble).
>
> Actually I think it would be better to define the total size of RAM
> for mx28evk as 128MB.
>
> Do you agree?
Yes, it's fine with me.
>
> Regards,
>
> Fabio Estevam
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound
2012-05-12 16:07 [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound Fabio Estevam
2012-05-12 16:10 ` Marek Vasut
@ 2012-05-12 21:22 ` Wolfgang Denk
1 sibling, 0 replies; 9+ messages in thread
From: Wolfgang Denk @ 2012-05-12 21:22 UTC (permalink / raw)
To: u-boot
Dear Fabio Estevam,
In message <1336838852-14235-1-git-send-email-festevam@gmail.com> you wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Scan only first 512 MB of DRAM to avoid memory wraparound.
>
> This fixes mx28evk boot and it follows the same idea of commit
> 19a2066b57 (M28: Scan only first 512 MB of DRAM to avoid memory wraparound)
Actually I think this should not be needed. Such wrap-arounds are
supposed to be detected by get_ram_size(), which should result in
properly sized RAM mappings.
Why is this failing here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He'd heard her use that sweet, innocent tone of voice before. It
meant that, pretty soon, there was going to be trouble.
- Terry Pratchett, _Truckers_
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-05-12 21:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-12 16:07 [U-Boot] [PATCH] mx28evk: Scan only first 512 MB of DRAM to avoid memory wraparound Fabio Estevam
2012-05-12 16:10 ` Marek Vasut
2012-05-12 16:14 ` Fabio Estevam
2012-05-12 16:19 ` Marek Vasut
2012-05-12 16:40 ` Fabio Estevam
2012-05-12 17:06 ` Marek Vasut
2012-05-12 16:51 ` Fabio Estevam
2012-05-12 17:07 ` Marek Vasut
2012-05-12 21:22 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox