From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: override compiler flags for cmd_nvedit
Date: Mon, 14 May 2012 01:24:19 -0400 [thread overview]
Message-ID: <201205140124.21449.vapier@gentoo.org> (raw)
In-Reply-To: <20120507163600.GA13121@nvidia.com>
On Monday 07 May 2012 12:36:00 Allen Martin wrote:
> On Sat, May 05, 2012 at 01:01:22PM -0700, Wolfgang Denk wrote:
> > Allen Martin wrote:
> > > Override -march setting for tegra to -march=armv4t for cmd_nvedit.c
> > >
> > > The recent change to use -march=armv7-a for armv7 caused a regression
> > > on tegra because tegra starts boot on a arm7tdmi processor before
> > > transferring control to the cortex-a9. While still executing on the
> > > arm7tdmi there is a call to getenv_ulong() that causes an illegal
> > > instruction exception if cmd_nvedit is compiled for armv7.
> > >
> > > Signed-off-by: Allen Martin <amartin@nvidia.com>
> > > ---
> > >
> > > common/Makefile | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> >
> > We definitely do not want to introduce board specific compile
> > options in common code, and especially not on a per-file base.
>
> The other option is to compile all of tegra armv4t by modifying
> arch/arm/cpu/armv7/config.mk
no it's not. arch and board config.mk get sourced, so you can put this
board/arch specific cruft there. we do it for blackfin boards all the time ...
see board/bf537-stamp/config.mk for example.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120514/50bd1c68/attachment.pgp>
next prev parent reply other threads:[~2012-05-14 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 20:29 [U-Boot] [PATCH] tegra: override compiler flags for cmd_nvedit Allen Martin
2012-05-05 20:01 ` Wolfgang Denk
2012-05-07 16:36 ` Allen Martin
2012-05-14 5:24 ` Mike Frysinger [this message]
2012-05-14 19:39 ` Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205140124.21449.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox