From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 2/3] create lib/tizen directory
Date: Tue, 15 May 2012 01:14:05 -0400 [thread overview]
Message-ID: <201205150114.07431.vapier@gentoo.org> (raw)
In-Reply-To: <CAH9JG2U_VDvvUJn7HhbiM2Ut7eR=nNi9A4G9XqnnySS4xeQ+qA@mail.gmail.com>
On Monday 14 May 2012 03:27:55 Kyungmin Park wrote:
> On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
> >> On 5/14/12, Mike Frysinger <vapier@gentoo.org> wrote:
> >> > On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
> >> >> Makefile | 1 +
> >> >> include/libtizen.h | 30 +
> >> >> lib/tizen/Makefile | 46 +
> >> >> lib/tizen/tizen.c | 40 +
> >> >> lib/tizen/tizen_hd_logo.h | 5071
> >> >> lib/tizen/tizen_hd_logo_data.h | 30 +
> >> >
> >> > do you really need your own lib/tizen/ dir for a logo ? every one who
> >> > doesn't
> >> > build this still has to waste time going into lib/tizen/ to create an
> >> > empty
> >> >
> >> > object. at least make the addition of lib/tizen/ depend on
> >> > CONFIG_TIZEN
> >> > too.
> >>
> >> It uses the same method as others does.
> >> e.g., libfdt
> >>
> >> In Makefile
> >> LIBS += lib/libfdt/libfdt.o
> >>
> >> In "lib/libfdt/Makefile"
> >> SOBJS =
> >>
> >> COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o
> >> fdt_wip.o
> >>
> >> COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt)
> >> COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
> >
> > the difference is they have more than one CONFIG symbol going on, and
> > their
> >
> > code base is sizable, and many arches/boards utilize it. you're adding a
> > single file with a single function with a single CONFIG knob for a single
> > board.
>
> Right, So we asked it first, which directory is proper. and suggested
> that the create the lib/tizen instead of others. since it's not
> platform, nor soc specific.
you can still do in the top level to avoid affecting other people:
ifeq ($(CONFIG_TIZEN),y)
LIBS += lib/tizen/libtizen.o
endif
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120515/fb96b4f3/attachment.pgp>
next prev parent reply other threads:[~2012-05-15 5:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 5:23 [U-Boot] [PATCH v5 2/3] create lib/tizen directory Donghwa Lee
2012-05-10 14:12 ` Minkyu Kang
2012-05-14 5:31 ` Mike Frysinger
2012-05-14 5:37 ` Kyungmin Park
2012-05-14 5:45 ` Mike Frysinger
2012-05-14 7:27 ` Kyungmin Park
2012-05-15 5:14 ` Mike Frysinger [this message]
2012-05-24 21:56 ` Anatolij Gustschin
[not found] <0M4500GCQ6DX82K0@ms2.samsung.com>
2012-05-17 0:54 ` Donghwa Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205150114.07431.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox