public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] Make i2c probe opt-outable?
Date: Thu, 17 May 2012 11:43:45 -0700	[thread overview]
Message-ID: <20120517184345.GA23562@bill-the-cat> (raw)

Hey all,

I'd like to propose making 'i2c probe' be a command that is
opt-out'able.  In the Linux Kernel the notion of probing for devices was
abandoned a while ago due to, in short, devices misbehaving when
randomly poked at.  Over in omap24xx_i2c land we changed our probe
method a while ago from an attempted read to an attempted write as some
i2c devices would NAK the read.  But now with the am33xx SoM family we
have a new issue which is that attempting to write to an address doesn't
immediately issue a NAK so probe sees all addresses as valid and in turn
leaves the bus upset.  I've worked around this for now by making
i2c_probe use the read method instead, only on am33xx (so most devices
would be spotted, but the ones that caused the initial change would not
show up).  But a possibly better solution is to just make the i2c probe
command not implemented for am33xx (as you don't have to run i2c probe
to try and use your device).

Thoughts?  Thanks!

-- 
Tom

             reply	other threads:[~2012-05-17 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17 18:43 Tom Rini [this message]
2012-05-18  2:48 ` [U-Boot] [RFC] Make i2c probe opt-outable? Mike Frysinger
2012-05-18 16:11   ` Tom Rini
2012-05-18 16:18     ` Mike Frysinger
2012-05-18 18:26     ` Wolfgang Denk
2012-05-18 18:43       ` Tom Rini
2012-05-18 21:52         ` Wolfgang Denk
2012-05-21 16:48           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120517184345.GA23562@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox