From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment
Date: Fri, 18 May 2012 00:18:07 +0200 [thread overview]
Message-ID: <20120517221808.2AEAE206271@gemini.denx.de> (raw)
In-Reply-To: <4FB12E88.1050906@freescale.com>
Dear Timur Tabi,
In message <4FB12E88.1050906@freescale.com> you wrote:
>
> > all these board hooks are paper-cutting us to death with unused bloat
>
> I know, and I don't like it either. I hate how our hardware designers are
> always breaking the "rules", forcing us software developers to hack up our
> software more and more. The muxing on this chip is a like a cruel joke
> being played on me. I've even been told that I'm trying too hard to make
> it work.
I think whoever told you this was right. Let it break.
We cannot add pre- and post-hooks all ever the place for brain-dead
designs that need to do this and that before and after doing perfectly
things.
It makes no sense adding this to saveenv, because there will be othe
rplaces in the code that need to to the same - like if it's NAND
flash, you will probabaly need to do the same for all NAND related
commands.
cmd_nvedit.c is definitely the wrong place for this.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Bradley's Bromide: If computers get too powerful, we can organize
them into a committee - that will do them in.
next prev parent reply other threads:[~2012-05-17 22:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 22:21 [U-Boot] [PATCH 1/6] powerpc/85xx: minor clean-ups to the P2020DS board header file Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 2/6] powerpc/85xx: fdt_set_phy_handle() should return an error code Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 3/6] powerpc/85xx: clean up P1022DS board configuration header file Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 4/6] lib/powerpc: addrmap_phys_to_virt() should return a pointer Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 5/6] cmd_nvedit.c: allow board-specific code before/after saving the environment Timur Tabi
2012-05-14 5:20 ` Mike Frysinger
2012-05-14 16:10 ` Timur Tabi
2012-05-15 5:14 ` Mike Frysinger
2012-05-17 22:18 ` Wolfgang Denk [this message]
2012-05-17 22:35 ` Timur Tabi
2012-05-18 2:46 ` Mike Frysinger
2012-05-18 11:28 ` Wolfgang Denk
2012-05-18 15:58 ` Timur Tabi
2012-05-18 16:02 ` Jeroen Hofstee
2012-05-18 18:24 ` Wolfgang Denk
2012-05-18 18:23 ` Wolfgang Denk
2012-05-18 18:29 ` Fabio Estevam
2012-05-17 22:48 ` Scott Wood
2012-05-17 22:53 ` Timur Tabi
2012-05-18 2:14 ` Scott Wood
2012-05-18 2:21 ` Tabi Timur-B04825
2012-05-18 2:30 ` Scott Wood
2012-05-18 16:00 ` Timur Tabi
2012-05-18 16:13 ` Scott Wood
2012-05-18 16:17 ` Timur Tabi
2012-05-18 16:29 ` Scott Wood
2012-05-18 17:08 ` Timur Tabi
2012-05-18 17:21 ` Scott Wood
2012-05-18 18:13 ` McClintock Matthew-B29882
2012-05-18 18:28 ` Wolfgang Denk
2012-05-17 21:18 ` Timur Tabi
2012-05-04 22:21 ` [U-Boot] [PATCH 6/6] powerpc/85xx: p1022ds: use the saveenv board preparation functions Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517221808.2AEAE206271@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox