public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 v3] FSL/eSDHC: enable the clock to detect the SD card
Date: Fri, 18 May 2012 18:03:15 +0200	[thread overview]
Message-ID: <201205181803.15326.marex@denx.de> (raw)
In-Reply-To: <1337335022-18501-2-git-send-email-Chang-Ming.Huang@freescale.com>

Dear Chang-Ming.Huang at freescale.com,

> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> 
> For FSL low-end processors (VVN2.2)

What's VVN2.2 ?

> , in order to detect the SD card,
> we should enable PEREN, HCKEN and IPGEN to enable the clock.
> Otherwise, after booting the u-boot, and then inserting the SD card,
> the SD card can't be detected.
> For SDHC VVN2.3 IP

VVN2.3 ?

> , these bits are reserved, and SDCLKEN is used.
> And when accessing to these reserved bit, no any impact happened.
> 
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> CC: Andy Fleming <afleming@gmail.com>
> CC: Marek Vasut <marex@denx.de>
> ---
> changes for v2:
> 	- correct the typo
> changes for v3:
> 	- enable all clock bits for VVN2.3 and VVN2.2
> 	- use funciton esdhc_setbits32
> 	- tested on p1022ds, p1025rdb, p1020mbg-pc, mpc8536ds, p3041ds
> 
>  drivers/mmc/fsl_esdhc.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index a2f35e3..930a5c5 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -491,6 +491,9 @@ int fsl_esdhc_initialize(bd_t *bis, struct
> fsl_esdhc_cfg *cfg) /* First reset the eSDHC controller */
>  	esdhc_reset(regs);
> 
> +	esdhc_setbits32(&regs->sysctl, SYSCTL_PEREN | SYSCTL_HCKEN
> +				| SYSCTL_IPGEN | SYSCTL_CKEN);
> +
>  	mmc->priv = cfg;
>  	mmc->send_cmd = esdhc_send_cmd;
>  	mmc->set_ios = esdhc_set_ios;

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-05-18 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  9:57 [U-Boot] [PATCH 1/2 v2] SDHC/MMC: fix the wrong infomation after change SD card Chang-Ming.Huang at freescale.com
2012-05-18  9:57 ` [U-Boot] [PATCH 2/2 v3] FSL/eSDHC: enable the clock to detect the " Chang-Ming.Huang at freescale.com
2012-05-18 15:55   ` Scott Wood
2012-05-21  2:34     ` Huang Changming-R66093
2012-07-11  9:31       ` Huang Changming-R66093
2012-07-13 10:36         ` Marek Vasut
2012-05-18 16:03   ` Marek Vasut [this message]
2012-05-21  2:19     ` Huang Changming-R66093
2012-07-11  9:29 ` [U-Boot] [PATCH 1/2 v2] SDHC/MMC: fix the wrong infomation after change " Huang Changming-R66093
2012-07-13 21:32   ` Andy Fleming
2012-07-14  5:00     ` Marek Vasut
2012-07-30  7:00     ` Huang Changming-R66093

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205181803.15326.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox