public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] ARM: add tegra support to arm720t
Date: Fri, 18 May 2012 15:37:14 -0700	[thread overview]
Message-ID: <20120518223714.GD30009@nvidia.com> (raw)
In-Reply-To: <4FB1E39C.3080806@wwwdotorg.org>

On Mon, May 14, 2012 at 10:03:24PM -0700, Stephen Warren wrote:
> On 05/10/2012 01:02 AM, Allen Martin wrote:
> > Add support for tegra arm7 boot processor.  This processor is used to
> > power on the Cortex A9 and transfer control to it.
> 
> > +static void enable_cpu_power_rail(void)
> 
> > +	/*
> > +	 * The TI PMU65861C needs a 3.75ms delay between enabling
> > +	 * the power rail and enabling the CPU clock.  This delay
> > +	 * between SM1EN and SM1 is for switching time + the ramp
> > +	 * up of the voltage to the CPU (VDD_CPU from PMU).
> > +	 */
> > +	udelay(3750);
> 
> Not all boards use that PMU. Can this be conditional on a define that
> enables that PMU, or part of the PMU diver or something?

Sounds reasonable, although I think it should be part of a separate
patch.  This code I just moved unmodified from ap20.c in the armv7
tegra2 directory.

> 
> > diff --git a/arch/arm/cpu/arm720t/tegra2/cpu.h b/arch/arm/cpu/arm720t/tegra2/cpu.h
> 
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License as
> > + * published by the Free Software Foundation; either version 2 of
> > + * the License, or (at your option) any later version.
> 
> Is this new code you just wrote? If so, shouldn't it be GPL v2 not GPL v2+?

Again I just moved it unmodified (copyright and all) from ap20.h.  

-Allen
-- 
nvpublic

  reply	other threads:[~2012-05-18 22:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10  7:02 [U-Boot] [PATCH 0/9] split tegra arm7 code into separate SPL Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 1/9] tegra2: move tegra2 SoC code to arch/arm/cpu/tegra2-common Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 2/9] mkconfig: add support for SPL CPU Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 3/9] ARM: Fix arm720t SPL build Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 4/9] tegra: Add SPL build support to tegra boards Allen Martin
2012-05-15  4:55   ` Stephen Warren
2012-05-18 22:42     ` Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 5/9] ARM: add tegra support to arm720t Allen Martin
2012-05-15  5:03   ` Stephen Warren
2012-05-18 22:37     ` Allen Martin [this message]
2012-05-22 17:10       ` Stephen Warren
2012-05-22 19:14         ` Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 6/9] tegra: enable SPL build for seaboard Allen Martin
2012-05-15  5:06   ` Stephen Warren
2012-05-18 22:24     ` Allen Martin
2012-05-22 17:07       ` Stephen Warren
2012-05-22 19:02         ` Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 7/9] tegra: add u-boot.t2 target Allen Martin
2012-05-15  5:08   ` Stephen Warren
2012-05-18 22:14     ` Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 8/9] tegra2: Remove CPU init code from tegra2 u-boot Allen Martin
2012-05-10  7:02 ` [U-Boot] [PATCH 9/9] tegra2: Remove USE_PRIVATE_LIBGCC and armv4t build flags Allen Martin
2012-05-15  5:11   ` Stephen Warren
2012-05-18 22:13     ` Allen Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120518223714.GD30009@nvidia.com \
    --to=amartin@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox