From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Fri, 18 May 2012 15:37:14 -0700 Subject: [U-Boot] [PATCH 5/9] ARM: add tegra support to arm720t In-Reply-To: <4FB1E39C.3080806@wwwdotorg.org> References: <1336633347-8049-1-git-send-email-amartin@nvidia.com> <1336633347-8049-6-git-send-email-amartin@nvidia.com> <4FB1E39C.3080806@wwwdotorg.org> Message-ID: <20120518223714.GD30009@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 14, 2012 at 10:03:24PM -0700, Stephen Warren wrote: > On 05/10/2012 01:02 AM, Allen Martin wrote: > > Add support for tegra arm7 boot processor. This processor is used to > > power on the Cortex A9 and transfer control to it. > > > +static void enable_cpu_power_rail(void) > > > + /* > > + * The TI PMU65861C needs a 3.75ms delay between enabling > > + * the power rail and enabling the CPU clock. This delay > > + * between SM1EN and SM1 is for switching time + the ramp > > + * up of the voltage to the CPU (VDD_CPU from PMU). > > + */ > > + udelay(3750); > > Not all boards use that PMU. Can this be conditional on a define that > enables that PMU, or part of the PMU diver or something? Sounds reasonable, although I think it should be part of a separate patch. This code I just moved unmodified from ap20.c in the armv7 tegra2 directory. > > > diff --git a/arch/arm/cpu/arm720t/tegra2/cpu.h b/arch/arm/cpu/arm720t/tegra2/cpu.h > > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation; either version 2 of > > + * the License, or (at your option) any later version. > > Is this new code you just wrote? If so, shouldn't it be GPL v2 not GPL v2+? Again I just moved it unmodified (copyright and all) from ap20.h. -Allen -- nvpublic