[U-Boot] [PATCH] nand_util: correct YAFFS image write function

[U-Boot] [PATCH] nand_util: correct YAFFS image write function

[Liu, Wentao]

In function nand_write_skip_bad(),for YAFFS filesystem part,
write_oob() will return 0 when success, so when rval equals 0,
it should continue to write the next page, and no break.

Signed-off-by: Wentao, Liu <wentao.liu@intel.com>

diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
index 60c778e..7ed8b18 100644
--- a/drivers/mtd/nand/nand_util.c
+++ b/drivers/mtd/nand/nand_util.c
@@ -564,7 +564,7 @@ int nand_write_skip_bad(nand_info_t *nand, loff_t offset, size_t *length,
 				ops.oobbuf = ops.datbuf + pagesize;
 
 				rval = nand->write_oob(nand, offset, &ops);
-				if (!rval)
+				if (rval != 0)
 					break;
 
 				offset += pagesize;
-- 
1.7.4.1

[U-Boot] [PATCH] nand_util: correct YAFFS image write function

[Kassey Lee]

hi, Lei, Scott:
     I think this is correct,
     do you have some comments ?

thanks!

BR.
Kassey


2012/1/18 Liu, Wentao <wentao.liu@intel.com>:
> In function nand_write_skip_bad(),for YAFFS filesystem part,
> write_oob() will return 0 when success, so when rval equals 0,
> it should continue to write the next page, and no break.
>
> Signed-off-by: Wentao, Liu <wentao.liu@intel.com>
>
> diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c
> index 60c778e..7ed8b18 100644
> --- a/drivers/mtd/nand/nand_util.c
> +++ b/drivers/mtd/nand/nand_util.c
> @@ -564,7 +564,7 @@ int nand_write_skip_bad(nand_info_t *nand, loff_t offset, size_t *length,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?ops.oobbuf = ops.datbuf + pagesize;
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?rval = nand->write_oob(nand, offset, &ops);
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (!rval)
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? if (rval != 0)
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?break;
>
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?offset += pagesize;
> --
> 1.7.4.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



--
Best regards
Kassey

Intel Mobile Communication ?Xi'an, China PRC

[U-Boot] [PATCH] nand_util: correct YAFFS image write function

[Scott Wood]

On 01/20/2012 12:17 AM, Kassey Lee wrote:
> hi, Lei, Scott:
>      I think this is correct,
>      do you have some comments ?

Looks right.

-Scott

[U-Boot] [PATCH] nand_util: correct YAFFS image write function

[Lei Wen]

On Sat, Jan 21, 2012 at 4:46 AM, Scott Wood <scottwood@freescale.com> wrote:
> On 01/20/2012 12:17 AM, Kassey Lee wrote:
>> hi, Lei, Scott:
>> ? ? ?I think this is correct,
>> ? ? ?do you have some comments ?
>
> Looks right.
>
> -Scott


Also looks fine to me.
Acked-by: Lei Wen <leiwen@marvell.com>

Best regards,
Lei

[U-Boot] nand_util: correct YAFFS image write function

[Scott Wood]

On Tue, Jan 17, 2012 at 07:55:02PM -0000, Liu wrote:
> In function nand_write_skip_bad(),for YAFFS filesystem part,
> write_oob() will return 0 when success, so when rval equals 0,
> it should continue to write the next page, and no break.
> 
> Signed-off-by: Wentao, Liu <wentao.liu@intel.com>
> Acked-by: Lei Wen <leiwen@marvell.com>

Applied to u-boot-nand-flash (sorry about the delay)

-Scott