From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Added watchdog support for davinchi_dm365evm
Date: Sun, 20 May 2012 14:59:27 -0400 [thread overview]
Message-ID: <201205201459.28436.vapier@gentoo.org> (raw)
In-Reply-To: <1337532640-1310-1-git-send-email-stijn.souffriau@essensium.com>
On Sunday 20 May 2012 12:50:40 Stijn Souffriau wrote:
> --- a/board/davinci/dm365evm/dm365evm.c
> +++ b/board/davinci/dm365evm/dm365evm.c
>
> +#ifdef CONFIG_HW_WATCHDOG
> +static struct davinci_timer * const wdttimer =
> + (struct davinci_timer *)CONFIG_SYS_WDTTIMERBASE;
> +
> +/* WDTCR bit definitions */
> +#define WDEN (1 << 14)
> +#define WDFLAG (1 << 15)
> +#define WDKEY_SEQ0 (0xa5c6 << 16)
> +#define WDKEY_SEQ1 (0xda7e << 16)
if this is an on-chip hardware block, this stuff should be in an SoC-specific
header
> --- a/include/configs/davinci_dm365evm.h
> +++ b/include/configs/davinci_dm365evm.h
>
> +// Hardware watchdog config
don't use // comment blocks. use /* ... */.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120520/f0a334a7/attachment.pgp>
next prev parent reply other threads:[~2012-05-20 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-20 16:50 [U-Boot] [PATCH] Added watchdog support for davinchi_dm365evm Stijn Souffriau
2012-05-20 18:59 ` Mike Frysinger [this message]
2012-06-02 15:32 ` Stijn Souffriau
2012-07-19 13:28 ` Mike Frysinger
2012-05-21 6:17 ` Heiko Schocher
2012-06-02 15:30 ` Stijn Souffriau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205201459.28436.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox