public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Added u-boot header generating functionality to ublimage
Date: Sun, 20 May 2012 15:00:14 -0400	[thread overview]
Message-ID: <201205201500.15804.vapier@gentoo.org> (raw)
In-Reply-To: <1337532786-1374-1-git-send-email-stijn.souffriau@essensium.com>

On Sunday 20 May 2012 12:53:06 Stijn Souffriau wrote:
> --- a/tools/ublimage.c
> +++ b/tools/ublimage.c
> 
> +static uint32_t getDataPageSize() {

don't use CamelCase in naming things.  use "(void)" not "()".  uncuddle the 
brace with function definitions.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120520/19c924b4/attachment.pgp>

  reply	other threads:[~2012-05-20 19:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20 16:53 [U-Boot] [PATCH] Added u-boot header generating functionality to ublimage Stijn Souffriau
2012-05-20 19:00 ` Mike Frysinger [this message]
2012-05-21  6:30 ` Heiko Schocher
2012-06-02 15:39   ` Stijn Souffriau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205201500.15804.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox