[U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

[U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

[Joe Hershberger]

Fix this warning:
smc911x.c: In function 'smc911x_initialize':
smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default]

Tested on omap3_overo

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
---
 drivers/net/smc911x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index e34b487..3911989 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -162,7 +162,7 @@ static int smc911x_init(struct eth_device *dev, bd_t * bd)
 }
 
 static int smc911x_send(struct eth_device *dev,
-			volatile void *packet, int length)
+			void *packet, int length)
 {
 	u32 *data = (u32*)packet;
 	u32 tmplen;
-- 
1.6.0.2

[U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

[Anatolij Gustschin]

Hi Joe,

On Mon, 21 May 2012 12:21:53 -0500
Joe Hershberger <joe.hershberger@ni.com> wrote:

> Fix this warning:
> smc911x.c: In function 'smc911x_initialize':
> smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default]

just a note: some patches for similar issues already exist
on patchwork:

http://patchwork.ozlabs.org/patch/160294/
http://patchwork.ozlabs.org/patch/160293/
http://patchwork.ozlabs.org/patch/160292/
http://patchwork.ozlabs.org/patch/160291/

unfortunately I forgot to cc you, sorry.

Thanks,
Anatolij

[U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

[Joe Hershberger]

Hi Anatolij,

On Mon, May 21, 2012 at 1:11 PM, Anatolij Gustschin <agust@denx.de> wrote:
> Hi Joe,
>
> On Mon, 21 May 2012 12:21:53 -0500
> Joe Hershberger <joe.hershberger@ni.com> wrote:
>
>> Fix this warning:
>> smc911x.c: In function 'smc911x_initialize':
>> smc911x.c:288:12: warning: assignment from incompatible pointer type [enabled by default]
>
> just a note: some patches for similar issues already exist
> on patchwork:
>
> http://patchwork.ozlabs.org/patch/160294/
> http://patchwork.ozlabs.org/patch/160293/
> http://patchwork.ozlabs.org/patch/160292/
> http://patchwork.ozlabs.org/patch/160291/

Thanks for submitting the patches.  Were you able to test them out on
hardware?  If so, please comment what hardware.

Thanks,
-Joe

[U-Boot] [PATCH] net: Fix smc911x Ethernet driver warning

[Anatolij Gustschin]

Hi Joe,

On Mon, 21 May 2012 13:20:40 -0500
Joe Hershberger <joe.hershberger@gmail.com> wrote:
...
> > just a note: some patches for similar issues already exist
> > on patchwork:
> >
> > http://patchwork.ozlabs.org/patch/160294/
> > http://patchwork.ozlabs.org/patch/160293/
> > http://patchwork.ozlabs.org/patch/160292/
> > http://patchwork.ozlabs.org/patch/160291/
> 
> Thanks for submitting the patches.  Were you able to test them out on
> hardware?  If so, please comment what hardware.

I only tested the patch http://patchwork.ozlabs.org/patch/160291/
on the TQM5200 board. For other 4 patches I do not have the hardware
to test.

I'm going to fix drivers/net/4xx_enet.c, too. I have the HW to test it
and hope to submit a patch soon.

Thanks,

Anatolij