From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine
Date: Tue, 22 May 2012 17:51:00 +0200 [thread overview]
Message-ID: <20120522155100.1382F20716D@gemini.denx.de> (raw)
In-Reply-To: <4FBB6712.3040005@st.com>
Dear Amit Virdi,
In message <4FBB6712.3040005@st.com> you wrote:
>
> Alright, I shall be soon sending V5 that drops this patch and uses
> __change_bit directly.
It would be a much better investment in time if you come up with
patches that help to _avoid_ usign this horrible function, and
eventually removig it from U-Boot.
change_bit() is inherently not portable and actual behaviour is
largely undefined, so please do NOT use this function in any new code.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Immortality consists largely of boredom.
-- Zefrem Cochrane, "Metamorphosis", stardate 3219.8
next prev parent reply other threads:[~2012-05-22 15:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 6:00 [U-Boot] [PATCH V4 0/4] mtd/NAND: Support for FSMC controller Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 1/4] ARM: Define change_bit routine Amit Virdi
2012-05-18 15:43 ` Scott Wood
2012-05-22 10:14 ` Amit Virdi
2012-05-22 15:51 ` Wolfgang Denk [this message]
2012-05-24 4:18 ` Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 2/4] mtd/NAND: Add FSMC driver support Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 3/4] SPEAr: Configure FSMC driver for NAND interface Amit Virdi
2012-05-18 6:00 ` [U-Boot] [PATCH V4 4/4] mtd/NAND: Remove obsolete SPEAr specific NAND drivers Amit Virdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120522155100.1382F20716D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox