From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 22 May 2012 20:03:52 +0200 Subject: [U-Boot] [PATCH V2 1/2] Add env vars describing U-Boot target board In-Reply-To: <4FBBBBCC.5020309@wwwdotorg.org> References: <1337643054-17290-1-git-send-email-swarren@wwwdotorg.org> <20120522082356.5C78C200239@gemini.denx.de> <4FBBBBCC.5020309@wwwdotorg.org> Message-ID: <20120522180353.073C8207166@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephen, In message <4FBBBBCC.5020309@wwwdotorg.org> you wrote: > > >> +echo "#define ARCH \"${arch}\"" >> config.h > >> +echo "#define CPU \"${cpu}\"" >> config.h > >> +echo "#define BOARD \"${board}\"" >> config.h > > > > Sorry, but names like ARCH and CPU are _way_ too intrusive and likely > > to clash. Please use something like CONFIG_SYS_ARCH_NAME etc. > > instead. > > OK. Are you OK with the environment variable names? They're also common > names like arch, cpu, board, vendor, soc. We don;t have any rules yet for environment variable names, or name spaces or the like, so I see no problems here. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Infidels in all ages have battled for the rights of man, and have at all times been the fearless advocates of liberty and justice." - Robert Green Ingersoll