public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4 V2] USB: Drop cache flush bloat in EHCI-HCD
Date: Thu, 24 May 2012 08:57:24 +0200	[thread overview]
Message-ID: <20120524085724.3f2e50c0@wker> (raw)
In-Reply-To: <1333946851-27904-1-git-send-email-marex@denx.de>

Hi Marek,

On Mon,  9 Apr 2012 06:47:31 +0200
Marek Vasut <marex@denx.de> wrote:

> Discard the creepy cache flushing mechanisms in ehci-hcd.c and replace them with
> more straightforward flushing. In the new approach, the flushing takes place
> directly in ehci_submit_async() call instead of going through the QH list and
> flushing all members and buffers. This discards a lot of weird bit operations
> on the members of QH and qTD structures.
> 
> NOTE: Certainly, this flushes even qTDs which are possibly unused in some
> transactions, though the overhead of the previous code was much higher than is
> the overhead of flushing two more cache lines (which most probably aren't even
> cached).
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Puneet Saxena <puneets@nvidia.com>
> ---
>  drivers/usb/host/ehci-hcd.c |  127 +++++++++----------------------------------
>  1 files changed, 27 insertions(+), 100 deletions(-)

Unfortunately this patch breaks compiling for many powerpc boards, mpc512x,
mpc83xx, mpc85xx and QorIQ Px based with USB support enabled.

Thanks,
Anatolij

  reply	other threads:[~2012-05-24  6:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09  3:09 [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 1/4] USB: Align buffers at cacheline Marek Vasut
2012-04-09  4:49   ` [U-Boot] [PATCH 1/4 V2] " Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 2/4] USB: Drop ehci_alloc/ehci_free in ehci-hcd Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 3/4] USB: Drop cache flush bloat in EHCI-HCD Marek Vasut
2012-04-09  4:47   ` [U-Boot] [PATCH 3/4 V2] " Marek Vasut
2012-05-24  6:57     ` Anatolij Gustschin [this message]
2012-05-24 13:21       ` Marek Vasut
2012-05-29  8:24         ` Liu Gang
2012-05-29  8:36           ` Marek Vasut
2012-04-09  3:09 ` [U-Boot] [PATCH 4/4] USB: Document the QH and qTD antics " Marek Vasut
2012-04-27  5:31   ` Mike Frysinger
2012-04-09  3:12 ` [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled Marek Vasut
2012-04-09  7:33   ` puneets
2012-04-09  7:41     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120524085724.3f2e50c0@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox