public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC
Date: Fri, 25 May 2012 13:04:12 +0200	[thread overview]
Message-ID: <20120525130412.135283e9@wker> (raw)
In-Reply-To: <1337676449-31346-1-git-send-email-voice.shen@atmel.com>

Hi,

On Tue, 22 May 2012 16:47:29 +0800
Bo Shen <voice.shen@atmel.com> wrote:
...
> diff --git a/drivers/video/atmel_hlcdfb.c b/drivers/video/atmel_hlcdfb.c
> new file mode 100644
> index 0000000..0fd7800
> --- /dev/null
> +++ b/drivers/video/atmel_hlcdfb.c
...
> +#define lcdc_readl(mmio, reg)		__raw_readl((mmio)+(reg))
> +#define lcdc_writel(mmio, reg, val)	__raw_writel((val), (mmio)+(reg))

Wolfgang won't accept base + offset for register access, we should use
struct instead. Converted patch is on the way, please review/test.

Thanks,
Anatolij

  parent reply	other threads:[~2012-05-25 11:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  8:47 [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC Bo Shen
2012-05-25 10:59 ` [U-Boot] [PATCH v3] video: atmel/lcd: add LCD driver for new Atmel SoC Anatolij Gustschin
2012-05-28  7:33   ` Bo Shen
2012-06-04 20:54   ` Anatolij Gustschin
2012-05-25 11:04 ` Anatolij Gustschin [this message]
2012-05-28  7:31   ` [U-Boot] [PATCH v2] video: atmel/lcd: add LCD driver for Atmel new SoC Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120525130412.135283e9@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox