public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] MPC8xxx: Define cache ops for USB
Date: Fri, 25 May 2012 18:13:22 +0200	[thread overview]
Message-ID: <201205251813.23208.marex@denx.de> (raw)
In-Reply-To: <OF23BF8EC1.5CB51E86-ONC1257A09.00500152-C1257A09.00501536@transmode.se>

Dear Joakim Tjernlund,

> > Hello Marek,
> > 
> > On 5/25/2012 7:44 PM, Marek Vasut wrote:
> > > This patch conditionally defines flush_dcache_range() and
> > > invalidate_dcache_range() on MPC8xxx, to avoid EHCI complaining,
> > 
> > > resulting in the following output:
> > <snip>
> > 
> > > +
> > > +void invalidate_dcache_range(unsigned long start, unsigned long stop)
> > > +{
> > > +}
> > > +
> > > +void flush_dcache_range(unsigned long start, unsigned long stop)
> > > +{
> > > +}
> > 
> > Don't mind if this is a stupid question.
> > Can't this be placed in some common header?
> > Just to avoid code duplication!
> 
> And why are they just dummy functions? There are cache flush instructions
> for ppc

Doesn't the PPC have it's own internal snooping?

Best regards,
Marek Vasut

  reply	other threads:[~2012-05-25 16:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 12:24 [U-Boot] [PATCH] MPC8xxx: Define cache ops for USB Marek Vasut
2012-05-25 14:14 ` [U-Boot] [PATCH V2] " Marek Vasut
2012-05-25 14:29   ` Vikram Narayanan
2012-05-25 14:34     ` Joakim Tjernlund
2012-05-25 16:13       ` Marek Vasut [this message]
2012-06-07 21:30   ` Wolfgang Denk
2012-05-29  8:58 ` [U-Boot] [PATCH] " Liu Gang
2012-05-29  9:02   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201205251813.23208.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox