From: Michael Walle <michael@walle.cc>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] kirkwood: add kirkwood_mpp_save/restore functions
Date: Tue, 29 May 2012 00:07:36 +0200 [thread overview]
Message-ID: <201205290007.36284.michael@walle.cc> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D1A2FB28A29@SC-VEXCH4.marvell.com>
Am Donnerstag 24 Mai 2012, 10:26:44 schrieb Prafulla Wadaskar:
> > +
> > +void kirkwood_mpp_save(void)
>
> This should be
> void kirkwood_mpp_save(unsigned int *mpp_ctrl, int len)
>
> > +{
> > + int i;
> > +
> > + for (i = 0; i < MPP_NR_REGS; i++)
> > + mpp_regs[i] = readl(MPP_CTRL(i));
> > +}
> > +
> > +void kirkwood_mpp_restore(void)
>
> Same here
> void kirkwood_mpp_restore(unsigned int *mpp_ctrl, int len)
or even better kirkwood_mpp_restore(const unsigned int *mpp_ctrl, int len)
btw. sometimes "unsigned int" is used and sometimes "u32", could we agree on
one? Eg. kirkwood_mpp_conf() is declared with unsigned int but defined with
u32.
--
Michael
next prev parent reply other threads:[~2012-05-28 22:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 10:53 [U-Boot] [PATCH 0/3] kirkwood spi_claim/release_bus support Valentin Longchamp
2012-05-16 10:53 ` [U-Boot] [PATCH 1/3] kirkwood: add kirkwood_mpp_save/restore functions Valentin Longchamp
2012-05-24 8:26 ` Prafulla Wadaskar
2012-05-28 22:07 ` Michael Walle [this message]
2012-05-29 12:42 ` Prafulla Wadaskar
2012-05-29 17:02 ` Michael Walle
2012-05-29 8:44 ` Valentin Longchamp
2012-05-29 10:12 ` Prafulla Wadaskar
2012-05-29 11:28 ` Valentin Longchamp
2012-05-29 12:06 ` Prafulla Wadaskar
2012-05-29 12:50 ` Valentin Longchamp
2012-05-29 13:15 ` Prafulla Wadaskar
2012-05-29 14:47 ` Marek Vasut
2012-05-30 14:28 ` [U-Boot] patchwork cleanup Prafulla Wadaskar
2012-06-01 15:27 ` Marek Vasut
2012-05-16 10:53 ` [U-Boot] [PATCH 2/3] spi/kirkwood: support spi_claim/release_bus functions Valentin Longchamp
2012-05-24 8:35 ` Prafulla Wadaskar
2012-05-29 8:32 ` Valentin Longchamp
2012-05-29 10:29 ` Prafulla Wadaskar
2012-05-29 11:32 ` Valentin Longchamp
2012-05-16 10:53 ` [U-Boot] [PATCH 3/3] spi/kirkwood: add weak functions board_spi_claim/release_bus Valentin Longchamp
2012-05-24 8:38 ` Prafulla Wadaskar
2012-05-29 8:32 ` Valentin Longchamp
2012-05-29 12:13 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205290007.36284.michael@walle.cc \
--to=michael@walle.cc \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox