From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4 V2] USB: Drop cache flush bloat in EHCI-HCD
Date: Tue, 29 May 2012 10:36:00 +0200 [thread overview]
Message-ID: <201205291036.00537.marex@denx.de> (raw)
In-Reply-To: <1338279884.9314.38.camel@linux>
Dear Liu Gang,
> Hi Marek,
>
> On Thu, 2012-05-24 at 15:21 +0200, Marek Vasut wrote:
> > > > drivers/usb/host/ehci-hcd.c | 127
> > > > +++++++++---------------------------------- 1 files changed, 27
> > > > insertions(+), 100 deletions(-)
> > >
> > > Unfortunately this patch breaks compiling for many powerpc boards,
> > > mpc512x, mpc83xx, mpc85xx and QorIQ Px based with USB support enabled.
> >
> > Because they have broken cache implementation, right? I mean, they have
> > their own snooping methods, so they don't need the cache flushing at
> > all, but then, if they don't, these methods (dcache_flush() etc) should
> > be optimized to empty functions. Maybe we should implement them for
> > these CPUs then? btw. I thought these compiled before, hm...
>
> Now this patch has been applied at "master" branch, but the building for
> powerpc boards as Anatolij mentioned will be failed.
> So Which platforms this patch applies to? If they all can not flush
> cache like the powerpc snooping methods?
I already submitted a patch for this issue
http://www.mail-archive.com/u-boot at lists.denx.de/msg84629.html
> Thanks!
>
> Best Regards!
>
> Liu Gang
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-29 8:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 3:09 [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled Marek Vasut
2012-04-09 3:09 ` [U-Boot] [PATCH 1/4] USB: Align buffers at cacheline Marek Vasut
2012-04-09 4:49 ` [U-Boot] [PATCH 1/4 V2] " Marek Vasut
2012-04-09 3:09 ` [U-Boot] [PATCH 2/4] USB: Drop ehci_alloc/ehci_free in ehci-hcd Marek Vasut
2012-04-09 3:09 ` [U-Boot] [PATCH 3/4] USB: Drop cache flush bloat in EHCI-HCD Marek Vasut
2012-04-09 4:47 ` [U-Boot] [PATCH 3/4 V2] " Marek Vasut
2012-05-24 6:57 ` Anatolij Gustschin
2012-05-24 13:21 ` Marek Vasut
2012-05-29 8:24 ` Liu Gang
2012-05-29 8:36 ` Marek Vasut [this message]
2012-04-09 3:09 ` [U-Boot] [PATCH 4/4] USB: Document the QH and qTD antics " Marek Vasut
2012-04-27 5:31 ` Mike Frysinger
2012-04-09 3:12 ` [U-Boot] [PATCH 0/4] USB: Fix EHCI to work with data cache enabled Marek Vasut
2012-04-09 7:33 ` puneets
2012-04-09 7:41 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205291036.00537.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox