From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 29 May 2012 10:36:00 +0200
Subject: [U-Boot] [PATCH 3/4 V2] USB: Drop cache flush bloat in EHCI-HCD
In-Reply-To: <1338279884.9314.38.camel@linux>
References: <1333940992-15484-4-git-send-email-marex@denx.de>
	<201205241521.30573.marex@denx.de> <1338279884.9314.38.camel@linux>
Message-ID: <201205291036.00537.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Liu Gang,

> Hi Marek,
> 
> On Thu, 2012-05-24 at 15:21 +0200, Marek Vasut wrote:
> > > >  drivers/usb/host/ehci-hcd.c |  127
> > > >  +++++++++---------------------------------- 1 files changed, 27
> > > >  insertions(+), 100 deletions(-)
> > > 
> > > Unfortunately this patch breaks compiling for many powerpc boards,
> > > mpc512x, mpc83xx, mpc85xx and QorIQ Px based with USB support enabled.
> > 
> > Because they have broken cache implementation, right? I mean, they have
> > their own snooping methods, so they don't need the cache flushing at
> > all, but then, if they don't, these methods (dcache_flush() etc) should
> > be optimized to empty functions. Maybe we should implement them for
> > these CPUs then? btw. I thought these compiled before, hm...
> 
> Now this patch has been applied at "master" branch, but the building for
> powerpc boards as Anatolij mentioned will be failed.
> So Which platforms this patch applies to? If they all can not flush
> cache like the powerpc snooping methods?

I already submitted a patch for this issue

http://www.mail-archive.com/u-boot at lists.denx.de/msg84629.html

> Thanks!
> 
> Best Regards!
> 
> Liu Gang

Best regards,
Marek Vasut