From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/8] mxsboot: stop referring to i.MX28 as this ought to work for all i.MXS SoCs
Date: Wed, 30 May 2012 07:49:24 +0200 [thread overview]
Message-ID: <201205300749.24350.marex@denx.de> (raw)
In-Reply-To: <20120529204422.8B5F62073AD@gemini.denx.de>
Dear Wolfgang Denk,
> Dear Otavio Salvador,
>
> In message <1336866018-614-5-git-send-email-otavio@ossystems.com.br> you
wrote:
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > ---
> >
> > tools/mxsboot.c | 110
> > +++++++++++++++++++++++++++---------------------------- 1 file changed,
> > 55 insertions(+), 55 deletions(-)
> >
> > diff --git a/tools/mxsboot.c b/tools/mxsboot.c
> > index 6c05aa4..9661a48 100644
> > --- a/tools/mxsboot.c
> > +++ b/tools/mxsboot.c
> > @@ -1,5 +1,5 @@
> >
> > /*
> >
> > - * Freescale i.MX28 image generator
> > + * Freescale i.MXS image generator
>
> I'm unhappy about the name "i.MXS".
I'm unhappy about the image generator ;-)
Ok, now Otavio will probably hate me, but I believe it'd be much more helpful to
convert mxsboot into part of mkimage (though this is unrelated to this patch).
And maybe even better, study the generation of boot headers and compare it with
mx53/mx6q ones, as mx53 ones are supported by imximage and mx28 carries direct
predecessor of mx53 bootrom and then try to implement support into imximage part
of mkimage.
> Either we say "i.MX28" - then
> it's clear we mean a specific FSL SoC, identified by it's product
> name. Or we say "mxs" like allover the place in the Linux and U-Boot
> code.
Well, we can also say i.mx233/i.mx28 . MX6Q is supported by mkimage I think (see
above).
> But I haven't seen "i.MXS" used before, and to me it makes no sense as
> it mixes unrelated name spaces.
>
> Please either use the Freescale name(s), or use "mxs".
>
> Thanks.
>
> Best regards,
>
> Wolfgang Denk
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-30 5:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-12 23:40 [U-Boot] [PATCH 0/8] Minor fixes and start of consolidation onto mxs SoC Otavio Salvador
2012-05-12 23:40 ` [U-Boot] [PATCH 1/8] m28evk: use same notation to alloc the 128kB stack Otavio Salvador
2012-05-29 20:44 ` Wolfgang Denk
2012-06-13 9:06 ` Stefano Babic
2012-05-12 23:40 ` [U-Boot] [PATCH 2/8] m28evk: use "M28EVK U-Boot =>" as prompt Otavio Salvador
2012-05-13 17:11 ` Marek Vasut
2012-05-29 20:41 ` Wolfgang Denk
2012-05-12 23:40 ` [U-Boot] [PATCH 3/8] mx28evk: ensure command definition is in alphabetic order Otavio Salvador
2012-05-13 19:29 ` Fabio Estevam
2012-06-13 9:06 ` Stefano Babic
2012-05-12 23:40 ` [U-Boot] [PATCH 4/8] mxsboot: stop referring to i.MX28 as this ought to work for all i.MXS SoCs Otavio Salvador
2012-05-13 17:12 ` Marek Vasut
2012-05-13 18:19 ` Otavio Salvador
2012-05-29 20:44 ` Wolfgang Denk
2012-05-29 21:25 ` Otavio Salvador
2012-05-29 21:32 ` Wolfgang Denk
2012-05-29 21:53 ` Otavio Salvador
2012-05-30 5:49 ` Marek Vasut [this message]
2012-05-30 12:01 ` Otavio Salvador
2012-06-02 7:06 ` [U-Boot] mxsboot vs. imximage (was: Re: [PATCH 4/8] mxsboot: stop referring to i.MX28 as this ought to work for all i.MXS SoCs) Dirk Behme
2012-06-02 7:21 ` Marek Vasut
2012-05-12 23:40 ` [U-Boot] [PATCH 5/8] m28evk: fix board config include guardian macro name Otavio Salvador
2012-05-13 17:12 ` Marek Vasut
2012-05-13 18:46 ` Wolfgang Denk
2012-05-13 18:53 ` Marek Vasut
2012-06-13 9:07 ` Stefano Babic
2012-05-12 23:40 ` [U-Boot] [PATCH 6/8] mx28evk: " Otavio Salvador
2012-05-13 19:31 ` Fabio Estevam
2012-06-13 9:06 ` Stefano Babic
2012-05-12 23:40 ` [U-Boot] [PATCH 7/8] mxs: reorganize source directory for easy sharing of code in i.MXS SoCs Otavio Salvador
2012-05-12 23:40 ` [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix Otavio Salvador
2012-05-13 17:15 ` Marek Vasut
2012-05-13 18:23 ` Otavio Salvador
2012-05-13 18:46 ` Marek Vasut
2012-05-14 17:09 ` Otavio Salvador
2012-05-14 18:25 ` Marek Vasut
2012-05-14 18:48 ` Otavio Salvador
2012-05-15 4:14 ` Marek Vasut
2012-05-29 20:47 ` [U-Boot] [PATCH 0/8] Minor fixes and start of consolidation onto mxs SoC Wolfgang Denk
2012-05-29 20:58 ` Otavio Salvador
-- strict thread matches above, loose matches on Subject: below --
2012-05-29 21:35 [U-Boot] [PATCH 4/8] mxsboot: stop referring to i.MX28 as this ought to work for all i.MXS SoCs Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205300749.24350.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox