From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 31 May 2012 13:23:02 +0200 Subject: [U-Boot] [PATCH] bootcount: Move bootcount.c from arch/powerpc/lib to lib In-Reply-To: <4FC74B04.4070409@denx.de> References: <1338454713-16211-1-git-send-email-sr@denx.de> <4FC74B04.4070409@denx.de> Message-ID: <201205311323.02153.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On Thursday 31 May 2012 12:42:12 Heiko Schocher wrote: > > diff --git a/arch/powerpc/lib/bootcount.c b/lib/bootcount.c > > similarity index 100% > > rename from arch/powerpc/lib/bootcount.c > > rename to lib/bootcount.c > > If we do this, we should try to move all bootcounter implementations > to this file, see: > > [hs at pollux u-boot]$ grep -lr bootcount_store . > ./common/main.c > ./arch/powerpc/lib/bootcount.c > ./arch/arm/cpu/arm926ejs/at91/cpu.c > ./arch/arm/cpu/armv7/highbank/bootcount.c > ./arch/arm/cpu/ixp/cpu.c > ./arch/blackfin/cpu/bootcount.c > ./board/enbw/enbw_cmc/enbw_cmc.c > ./board/omicron/calimain/calimain.c > ./board/keymile/km_arm/km_arm.c > ./include/common.h > [hs at pollux u-boot]$ > > and should provide a possibility to add board specific code, > for example needed for the > > board/keymile/km_arm/km_arm.c boards. > > Have you done a "MAKEALL arm"? I think (didn;t tried it) this > would fail with your patch ... No. You're right. It fails for some boards. I'll try to come up with a more generic solution to enable those board specific implementations. Thanks, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de