From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] tegra: usb: fix wrong error check
Date: Thu, 31 May 2012 15:14:53 +0200 [thread overview]
Message-ID: <201205311514.53821.marek.vasut@gmail.com> (raw)
In-Reply-To: <1338465062-30660-2-git-send-email-dev@lynxeye.de>
Dear Lucas Stach,
> loop_count runs down from 10000, so the correct condition to error out
> is ==0.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> CC: Stephen Warren <swarren@wwwdotorg.org>
> CC: Tom Warren <twarren.nvidia@gmail.com>
> ---
> arch/arm/cpu/armv7/tegra2/usb.c | 2 +-
> 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
>
> diff --git a/arch/arm/cpu/armv7/tegra2/usb.c
> b/arch/arm/cpu/armv7/tegra2/usb.c index c80de7f..5f2b243 100644
> --- a/arch/arm/cpu/armv7/tegra2/usb.c
> +++ b/arch/arm/cpu/armv7/tegra2/usb.c
Why isn't this file in drivers/usb/ ?
> @@ -290,7 +290,7 @@ static int init_usb_controller(struct fdt_usb *config,
> break;
> udelay(1);
> }
> - if (loop_count == 100000)
> + if (!loop_count)
> return -1;
>
> return 0;
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-05-31 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 11:51 [U-Boot] [PATCH 1/2] tegra: add ULPI on USB2 funcmux entry Lucas Stach
2012-05-31 11:51 ` [U-Boot] [PATCH 2/2] tegra: usb: fix wrong error check Lucas Stach
2012-05-31 13:14 ` Marek Vasut [this message]
2012-05-31 17:44 ` Stephen Warren
[not found] ` <5FBF8E85CA34454794F0F7ECBA79798F379C416005@HQMAIL04.nvidia.com>
2012-05-31 19:43 ` [U-Boot] [PATCH 1/2] tegra: add ULPI on USB2 funcmux entry Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205311514.53821.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox