From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 31 May 2012 15:14:53 +0200 Subject: [U-Boot] [PATCH 2/2] tegra: usb: fix wrong error check In-Reply-To: <1338465062-30660-2-git-send-email-dev@lynxeye.de> References: <1338465062-30660-1-git-send-email-dev@lynxeye.de> <1338465062-30660-2-git-send-email-dev@lynxeye.de> Message-ID: <201205311514.53821.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lucas Stach, > loop_count runs down from 10000, so the correct condition to error out > is ==0. > > Signed-off-by: Lucas Stach > Acked-by: Stephen Warren > CC: Stephen Warren > CC: Tom Warren > --- > arch/arm/cpu/armv7/tegra2/usb.c | 2 +- > 1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-) > > diff --git a/arch/arm/cpu/armv7/tegra2/usb.c > b/arch/arm/cpu/armv7/tegra2/usb.c index c80de7f..5f2b243 100644 > --- a/arch/arm/cpu/armv7/tegra2/usb.c > +++ b/arch/arm/cpu/armv7/tegra2/usb.c Why isn't this file in drivers/usb/ ? > @@ -290,7 +290,7 @@ static int init_usb_controller(struct fdt_usb *config, > break; > udelay(1); > } > - if (loop_count == 100000) > + if (!loop_count) > return -1; > > return 0; Best regards, Marek Vasut