public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra: trimslice: fix a couple typos
Date: Fri, 1 Jun 2012 17:45:08 +0200	[thread overview]
Message-ID: <201206011745.08250.marex@denx.de> (raw)
In-Reply-To: <4FC8D6CD.2030609@wwwdotorg.org>

Dear Stephen Warren,

> On 06/01/2012 12:38 AM, Igor Grinberg wrote:
> > On 05/31/12 19:50, Stephen Warren wrote:
> >> On 05/31/2012 04:13 AM, Marek Vasut wrote:
> >>> Dear Igor Grinberg,
> >>> 
> >>>> On 05/30/12 19:45, Stephen Warren wrote:
> >>>>> From: Stephen Warren <swarren@nvidia.com>
> >>>>> 
> >>>>> Fix the .dts file USB unit addresses not to duplicate each-other.
> >>>>> 
> >>>>> Fix the board name string to indicate the vendor is Compulab not
> >>>>> NVIDIA.
> >>>>> 
> >>>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> >>>> 
> >>>> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> >>> 
> >>> Do we have one copy of the dts files here and one in Linux kernel tree?
> >>> Are they the same?
> >> 
> >> Both U-Boot and the kernel have their own copies of the .dts files.
> >> 
> >> In general, the U-Boot copy would be identical to what's in the kernel,
> >> or a pure subset since mostly the kernel's driver support is more
> >> advanced, so we've added more nodes to the DT.
> >> 
> >> That said, there are unfortunately some bizarre quirks in the way the
> >> U-Boot parses the device tree, such as requiring the /aliases node in
> >> order to enumerate at least some devices, the use of the Tegra clock
> >> binding that hasn't been incorporated into the kernel yet and is used
> >> for both clock and module reset functionality even though it's really
> >> only intended for clock functionality, and various other small
> >> properties that are U-Boot specific (although I forget if we managed to
> >> eliminate these all or not). These all end up causing differences
> >> between the two device tree files:-(
> > 
> > Thanks for the information.
> > 
> > I don't see any problem with having differences between the .dts files
> 
> > in kernel and U-Boot, because the way I see it:
> The issue isn't so much the duplicate files, but differing content.
> 
> The whole point about DT is that it's a pure representation of the
> hardware; there should be no software-dependent design or data in it.
> Put another way, both U-Boot and the Linux kernel (and indeed anything
> else) should expect the DT to be written according to the same
> "bindings" design. This doesn't preclude the U-Boot DT file being a
> strict subset of the kernel file it it needs less information, but what
> is in both should match.

Thanks for clearing it up!

> 
> > Also, IIRC, the intension was to remove the kernel .dts files after
> > "all bootloaders" know to boot the DT kernel...
> 
> I don't believe it's anything to do with bootloaders. Bootloaders are
> already (in the main) expected to provide the DTB to the kernel as a
> separate entity, irrespective of whether the DTB is built by the kernel
> boot process or from some other repository. (Although there is
> CONFIG_APPENDED_DTB to support cases where this isn't possible, it's
> much preferred not to use this). Moving the .dts files out of the kernel
> is more purely about finding a place to put them I think.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Best regards,
Marek Vasut

  reply	other threads:[~2012-06-01 15:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 16:45 [U-Boot] [PATCH] tegra: trimslice: fix a couple typos Stephen Warren
2012-05-31  8:47 ` Igor Grinberg
2012-05-31 10:13   ` Marek Vasut
2012-05-31 16:50     ` Stephen Warren
2012-06-01  6:38       ` Igor Grinberg
2012-06-01 14:50         ` Stephen Warren
2012-06-01 15:45           ` Marek Vasut [this message]
2012-06-03  5:50             ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206011745.08250.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox