[U-Boot] [PATCH 1/2] menu: Added support to use user defined functions

Marek Vasut
2012-06-03T10:27:39Z

Dear Pali Roh?r,

> On Sunday 03 June 2012 11:59:16 Marek Vasut wrote:
> > > --- a/include/menu.h
> > > +++ b/include/menu.h
> > > @@ -21,12 +21,14 @@
> > >
> > > struct menu;
> > >
> > > struct menu *menu_create(char *title, int timeout, int
> > > prompt,
> > >
> > > - void (*item_data_print)(void *));
> > > + void (*item_data_print)(void *),
> > > + char *(*item_data_choice)(void *),
> >
> > Where is this item_data_choice() used?
>
> This is alternative function for menu entry choice. It is used in
> function menu_interactive_choice. If item_data_choice is NULL
> default code with readline_into_buffer is used.
>
> ANSI bootmenu command (in next patch) is using its own function.

Hm so why not make this ANSI stuff one plugin and the other bootmenu stuff
another plugin (which will be default). Then you won't have to check if anything
is null.

Best regards,
Marek Vasut