From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Wed, 6 Jun 2012 12:42:10 -0700 Subject: [U-Boot] [PATCH v2 09/10] tegra20: Remove CPU init code from tegra20 u-boot In-Reply-To: <4FCF8A7D.2030004@wwwdotorg.org> References: <1338931225-12246-1-git-send-email-amartin@nvidia.com> <1338931225-12246-10-git-send-email-amartin@nvidia.com> <4FCF8A7D.2030004@wwwdotorg.org> Message-ID: <20120606194210.GH13311@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jun 06, 2012 at 09:51:09AM -0700, Stephen Warren wrote: > On 06/05/2012 03:20 PM, Allen Martin wrote: > > This code is now included in the tegra20 SPL > > > @@ -323,34 +91,10 @@ void init_pmc_scratch(void) > > > > /* ODMDATA is for kernel use to determine RAM size, LP config, etc. */ > > writel(CONFIG_SYS_BOARD_ODMDATA, &pmc->pmc_scratch20); > > - > > -#ifdef CONFIG_TEGRA2_LP0 > > - /* save Sdram params to PMC 2, 4, and 24 for WB0 */ > > - warmboot_save_sdram_params(); > > -#endif > > } > > Is that change intended, or was it a rebase mistake? > > > diff --git a/arch/arm/cpu/tegra20-common/board.c b/arch/arm/cpu/tegra20-common/board.c > > > @@ -69,6 +68,11 @@ int dram_init(void) > > { > > /* We do not initialise DRAM here. We just query the size */ > > gd->ram_size = query_sdram_size(); > > + > > +#ifdef CONFIG_TEGRA2_LP0 > > + /* save Sdram params to PMC 2, 4, and 24 for WB0 */ > > + warmboot_save_sdram_params(); > > +#endif > > Hmmm. That's more than just removing the code that's now in the AVP > directory. Separate patch? The patch description also doesn't say why > this change is necessary. This code was added since v1 of the patch series, and I had to move it because when I fixed it so we could use the normal lowlevel_init it gets called before the devicetree is initialized. I rolled it into this patch, but you're probably right, it would make more sense to be in it's own patch with a proper description. -Allen -- nvpublic