From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] 85xx platforms build broken due to flush dcache functions missing
Date: Thu, 7 Jun 2012 11:34:02 +0200 [thread overview]
Message-ID: <201206071134.02455.marex@denx.de> (raw)
In-Reply-To: <3E027F8168735B46AC006B1D0C7BB00207995B05@039-SN2MPN1-011.039d.mgd.msft.net>
Dear Zang Roy-R61911,
The patch "[PATCH V2] MPC8xxx: Define cache ops for USB" wasn't applied yet for
some reason. It fixes the issue.
> Hi, Marek
>
> When I build P5020DS_config with the current u-boot head, I got:
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:346: undefined
> reference to `flush_dcache_range'
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:348: undefined
> reference to `flush_dcache_range'
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:349: undefined
> reference to `flush_dcache_range'
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:372: undefined
> reference to `invalidate_dcache_range'
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:374: undefined
> reference to `invalidate_dcache_range'
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:376: undefined
> reference to `invalidate_dcache_range'
> /home/roy/CVS/upstream/u-boot/drivers/usb/host/ehci-hcd.c:386: undefined
> reference to `invalidate_dcache_range' make: *** [u-boot] Error 1
>
>
> I found it was caused by your commit :
>
> commit b8adb12095814260d2b5edb23663ddf0ab97b877
> Author: Marek Vasut <marex@denx.de>
> Date: Mon Apr 9 04:07:46 2012 +0200
>
> USB: Drop cache flush bloat in EHCI-HCD
>
> Discard the creepy cache flushing mechanisms in ehci-hcd.c and replace
> them more straightforward flushing. In the new approach, the flushing
> takes place directly in ehci_submit_async() call instead of going through
> the QH list an flushing all members and buffers. This discards a lot of
> weird bit operation on the members of QH and qTD structures.
>
> NOTE: Certainly, this flushes even qTDs which are possibly unused in
> some transactions, though the overhead of the previous code was much
> higher than the overhead of flushing two more cache lines (which most
> probably aren't ev cached).
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Do you have any comment? Your commit will break all 85xx platforms with USB
> controller. Thanks
> Roy
Best regards,
Marek Vasut
next parent reply other threads:[~2012-06-07 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3E027F8168735B46AC006B1D0C7BB00207995B05@039-SN2MPN1-011.039d.mgd.msft.net>
2012-06-07 9:34 ` Marek Vasut [this message]
2012-06-07 21:22 ` [U-Boot] 85xx platforms build broken due to flush dcache functions missing Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206071134.02455.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox