From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/designware: Add-on: Consecutive writes must have delay
Date: Fri, 08 Jun 2012 01:07:42 +0200 [thread overview]
Message-ID: <20120607230742.E3BDF200048@gemini.denx.de> (raw)
In-Reply-To: <71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com>
Dear Dinh,
In message <71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com> you wrote:
>
> > Sorry, but this commit message is misleading - I was expecting to see
> > something like udelay() in the code, but there wasn't any...
>
> Combining the 2 individual writes into a single write will also work.
> I'm just keeping in sync with commit # f6c4191f.
I understand this - but the commit message should match the code.
> Again, just keeping the code in sync with the previous commit that address this issue. If you like, I can change it to setbits_le32().
I think it would be cleaner, but if the rest of the code looks like
that, I will not insist.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...one of the main causes of the fall of the Roman Empire was that,
lacking zero, they had no way to indicate successful termination of
their C programs." - Robert Firth
prev parent reply other threads:[~2012-06-07 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 21:28 [U-Boot] [PATCH] net/designware: Add-on: Consecutive writes must have delay Dinh Nguyen
2012-06-07 22:32 ` Wolfgang Denk
[not found] ` <71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com>
2012-06-07 23:07 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120607230742.E3BDF200048@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox