From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Fri, 08 Jun 2012 01:07:42 +0200 Subject: [U-Boot] [PATCH] net/designware: Add-on: Consecutive writes must have delay In-Reply-To: <71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com> References: <1339104480-6191-1-git-send-email-dinguyen@altera.com> <20120607223203.5809620000C@gemini.denx.de> <71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com> Message-ID: <20120607230742.E3BDF200048@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Dinh, In message <71B37E0559AC6849A68C5BA94C509FB458298D3C24@SJ-ITMSG02.altera.priv.altera.com> you wrote: > > > Sorry, but this commit message is misleading - I was expecting to see > > something like udelay() in the code, but there wasn't any... > > Combining the 2 individual writes into a single write will also work. > I'm just keeping in sync with commit # f6c4191f. I understand this - but the commit message should match the code. > Again, just keeping the code in sync with the previous commit that address this issue. If you like, I can change it to setbits_le32(). I think it would be cleaner, but if the rest of the code looks like that, I will not insist. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "...one of the main causes of the fall of the Roman Empire was that, lacking zero, they had no way to indicate successful termination of their C programs." - Robert Firth