From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 9 Jun 2012 01:48:40 +0200
Subject: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in
	linux/compat.h header
In-Reply-To: <20120608234343.3874A2000F5@gemini.denx.de>
References: <1339176514-13137-1-git-send-email-marex@denx.de>
	<20120608234343.3874A2000F5@gemini.denx.de>
Message-ID: <201206090148.40933.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

> Dear Marek Vasut,
> 
> In message <1339176514-13137-1-git-send-email-marex@denx.de> you wrote:
> > -#define kzalloc(size, flags)	calloc(size, 1)
> > +#define kzalloc(size, flags)	calloc(1, size)
> 
> Does this make any practical difference?
> 
> I mean, are you aware of any problem that gets fixed by this patch, or
> even any kind of performance degradation?

No, I just blindly found it out when I was enraged and was hacking on filesystem 
code.

> "common/dlmalloc.src" says:
> 
> 	calloc(size_t unit, size_t quantity);
> 	   Returns a pointer to quantity * unit bytes, with all locations
> 	   set to zero.
> 
> Multiplication being commutative, I see zero effect in this patch?

Weeeeell, not in every algebraic system. It has zero effect, it's only about 
correctness [1]. Will applying this break anything?

[1] http://pubs.opengroup.org/onlinepubs/009695399/functions/calloc.html
> Best regards,
> 
> Wolfgang Denk

Best regards,
Marek Vasut