From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Fri, 8 Jun 2012 23:30:23 -0700 Subject: [U-Boot] [PATCH v3 08/14] tegra20: add SPL config options for tegra20 boards In-Reply-To: <4FD2DCC6.2040407@wwwdotorg.org> References: <1339190167-20320-1-git-send-email-amartin@nvidia.com> <1339190167-20320-9-git-send-email-amartin@nvidia.com> <4FD2DCC6.2040407@wwwdotorg.org> Message-ID: <20120609063022.GB28640@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 08, 2012 at 10:19:02PM -0700, Stephen Warren wrote: > On 06/08/2012 03:16 PM, Allen Martin wrote: > > Add SPL options to tegra20 config files and enable SPL build for > > tegra20 boards in boards.cfg > > > diff --git a/include/configs/tegra20-common.h b/include/configs/tegra20-common.h > > > @@ -183,7 +183,7 @@ > > #define PHYS_SDRAM_1 TEGRA20_SDRC_CS0 > > #define PHYS_SDRAM_1_SIZE 0x20000000 /* 512M */ > > > > -#define CONFIG_SYS_TEXT_BASE 0x00108000 > > +#define CONFIG_SYS_TEXT_BASE 0x00208000 > > Conceptually this change is fine, I just wonder if we need to move this > up as far as 0x00208000; doesn't that reserve an entire MiB of space for > the SPL, which means the U-Boot image as a whole will always grow an > entire MiB, hence there's another MiB of data to copy from flash when > booting? IIRC, the entire AVP+A9 U-Boot is only very roughly 256K and > presumably the SPL is much smaller, so can we bump this define down a bit? Good point. Part of the problem is I use the gap between the SPL and normal u-boot for the SPL heap and stack, but that's not really necessary, I could move them down to before the beginning of the SPL instead. I'll try to tighten this up. -Allen -- nvpublic