public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/8] EXT2 cleanup
Date: Sat, 9 Jun 2012 19:55:43 +0200	[thread overview]
Message-ID: <201206091955.43887.marex@denx.de> (raw)
In-Reply-To: <20120609175210.GR14756@titan.lakedaemon.net>

Dear Jason Cooper,

> Marek,
> 
> On Fri, Jun 08, 2012 at 07:31:45PM +0200, Marek Vasut wrote:
> > So, I cleaned up the ext2 filesystem code a bit. I tried to separate the
> > changes to increase the reviewability.
> > 
> > Marek Vasut (8):
> >   EXT2: Indent cleanup of dev.c
> >   EXT2: Indent cleanup ext2fs.c
> >   EXT2: Rework ext2fs_blockgroup() function
> >   EXT2: Rework ext2fs_read_file()
> >   EXT2: Rework ext2fs_read_symlink()
> >   EXT2: Rework ext2fs_find_file1()
> >   EXT2: Rework ext2fs_iterate_dir()
> >   EXT2: Rework ext2fs_read_block()
> >  
> >  fs/ext2/dev.c    |   74 +++---
> >  fs/ext2/ext2fs.c |  775
> >  +++++++++++++++++++++++++++--------------------------- 2 files changed,
> >  416 insertions(+), 433 deletions(-)
> 
> Shall I rebase my ext2load speedup patch[1] against this?  Or, wait for
> this to be merged?

Your patch looks great and I'm fine either way. Will these patches interfere 
with your patch too much? Can you help reviewing these please? I'd like the ext2 
code to get cleaner as it's a real mess now :-(

Wolfgang, which way do you prefer?

> thx,
> 
> Jason.
> 
> [1] http://www.mail-archive.com/u-boot at lists.denx.de/msg84977.html

Best regards,
Marek Vasut

  reply	other threads:[~2012-06-09 17:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-08 17:31 [U-Boot] [PATCH 0/8] EXT2 cleanup Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 1/8] EXT2: Indent cleanup of dev.c Marek Vasut
2012-08-09 20:01   ` Wolfgang Denk
2012-06-08 17:31 ` [U-Boot] [PATCH 2/8] EXT2: Indent cleanup ext2fs.c Marek Vasut
2012-06-28 19:48   ` Jason Cooper
2012-06-28 22:03     ` Marek Vasut
2012-08-09 20:02   ` Wolfgang Denk
2012-06-08 17:31 ` [U-Boot] [PATCH 3/8] EXT2: Rework ext2fs_blockgroup() function Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 4/8] EXT2: Rework ext2fs_read_file() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 5/8] EXT2: Rework ext2fs_read_symlink() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 6/8] EXT2: Rework ext2fs_find_file1() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 7/8] EXT2: Rework ext2fs_iterate_dir() Marek Vasut
2012-06-08 17:31 ` [U-Boot] [PATCH 8/8] EXT2: Rework ext2fs_read_block() Marek Vasut
2012-06-09  5:48 ` [U-Boot] [PATCH 0/8] EXT2 cleanup Jorgen Lundman
2012-06-09 10:38   ` Marek Vasut
2012-06-09 17:52 ` Jason Cooper
2012-06-09 17:55   ` Marek Vasut [this message]
2012-06-17 15:12 ` Marek Vasut
2012-06-28 13:52   ` Jason Cooper
2012-06-28 14:35     ` Marek Vasut
2012-06-28 14:48       ` Jason Cooper
2012-06-28 14:50         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206091955.43887.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox