From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 08/14] tegra20: add SPL config options for tegra20 boards
Date: Mon, 11 Jun 2012 12:05:24 -0700 [thread overview]
Message-ID: <20120611190524.GE6633@nvidia.com> (raw)
In-Reply-To: <CAPnjgZ3nKg-Trdux3bdxG=Bp+75P4tcCpApg_ZwxPyYRev+Ctg@mail.gmail.com>
On Sat, Jun 09, 2012 at 11:35:29AM -0700, Simon Glass wrote:
> Hi Allen,
>
> diff --git a/include/configs/tegra20-common-post.h b/include/configs/tegra20-common-post.h
> index b535934..6b046bd 100644
> --- a/include/configs/tegra20-common-post.h
> +++ b/include/configs/tegra20-common-post.h
> @@ -144,4 +144,69 @@
> TEGRA20_DEVICE_SETTINGS \
> BOOTCMDS_COMMON
>
> +/* overrides for SPL build here */
> +#ifdef CONFIG_SPL_BUILD
> +
> +/* remove devicetree support */
> +#ifdef CONFIG_OF_CONTROL
> +#undef CONFIG_OF_CONTROL
> +#endif
> +
> +/* remove SERIAL_MULTI */
> +#ifdef CONFIG_SERIAL_MULTI
> +#undef CONFIG_SERIAL_MULTI
> +#endif
> +
> +/* remove I2C support */
> +#ifdef CONFIG_TEGRA_I2C
> +#undef CONFIG_TEGRA_I2C
> +#endif
> +#ifdef CONFIG_CMD_I2C
> +#undef CONFIG_CMD_I2C
> +#endif
>
> This stuff is pretty ugly - would it not be better to make boards not define this in the CONFIG_SPL_BUILD case in the first place, rather than overriding them? As an example, I2C might be useful in SPL, but here it would be hard (or even uglier) to add.
That's what I had in previous versions of this series, but it seemed
even uglier, because it requires sprinkling "#ifndef CONFIG_SPL_BUILD"
through each of the tegra20 board configs.
-Allen
--
nvpublic
next prev parent reply other threads:[~2012-06-11 19:05 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 21:15 [U-Boot] [PATCH v3 0/14] split tegra20 arm7 code into separate SPL Allen Martin
2012-06-08 21:15 ` [U-Boot] [PATCH v3 01/14] tegra20: rename tegra2 -> tegra20 Allen Martin
2012-06-08 21:54 ` Tom Warren
2012-06-12 19:55 ` Allen Martin
2012-06-08 21:15 ` [U-Boot] [PATCH v3 02/14] tegra20: move tegra20 SoC code to arch/arm/cpu/tegra20-common Allen Martin
2012-06-08 21:15 ` [U-Boot] [PATCH v3 03/14] tegra20: rename CONFIG_MACH_TEGRA_GENERIC Allen Martin
2012-06-08 21:15 ` [U-Boot] [PATCH v3 04/14] mkconfig: add support for SPL CPU Allen Martin
2012-06-09 18:20 ` Simon Glass
2012-06-11 18:40 ` Allen Martin
2012-06-08 21:15 ` [U-Boot] [PATCH v3 05/14] ARM: Fix arm720t SPL build Allen Martin
2012-06-08 21:15 ` [U-Boot] [PATCH v3 06/14] tegra20: remove timer_init from " Allen Martin
2012-06-08 21:16 ` [U-Boot] [PATCH v3 07/14] ARM: add tegra20 support to arm720t Allen Martin
2012-06-08 21:48 ` Tom Warren
2012-06-09 5:15 ` Stephen Warren
2012-06-09 18:32 ` Simon Glass
2012-06-11 19:01 ` Allen Martin
2012-06-08 21:16 ` [U-Boot] [PATCH v3 08/14] tegra20: add SPL config options for tegra20 boards Allen Martin
2012-06-09 5:19 ` Stephen Warren
2012-06-09 6:30 ` Allen Martin
2012-06-09 18:35 ` Simon Glass
2012-06-11 19:05 ` Allen Martin [this message]
2012-06-11 20:17 ` Simon Glass
2012-06-08 21:16 ` [U-Boot] [PATCH v3 09/14] tegra20: add u-boot.t2 target Allen Martin
2012-06-09 5:21 ` Stephen Warren
2012-06-11 19:09 ` Allen Martin
2012-06-09 19:12 ` Simon Glass
2012-06-11 19:22 ` Allen Martin
2012-06-11 20:21 ` Simon Glass
2012-06-11 23:09 ` Allen Martin
2012-06-12 0:16 ` Simon Glass
2012-06-08 21:16 ` [U-Boot] [PATCH v3 10/14] tegra: move SDRAM param save to later in boot Allen Martin
2012-06-09 19:15 ` Simon Glass
2012-06-11 22:38 ` Allen Martin
2012-06-08 21:16 ` [U-Boot] [PATCH v3 11/14] tegra20: Remove CPU init code from tegra20 u-boot Allen Martin
2012-06-09 19:19 ` Simon Glass
2012-06-11 22:53 ` Allen Martin
2012-06-12 0:15 ` Simon Glass
2012-06-08 21:16 ` [U-Boot] [PATCH v3 12/14] tegra20: Remove armv4t build flags Allen Martin
2012-06-09 5:24 ` Stephen Warren
2012-06-09 6:34 ` Allen Martin
2012-06-09 19:23 ` Simon Glass
2012-06-09 19:23 ` Simon Glass
2012-06-08 21:16 ` [U-Boot] [PATCH v3 13/14] tegra20: plutux: change obj directory mkdir commands Allen Martin
2012-06-09 5:29 ` Stephen Warren
2012-06-09 6:36 ` Allen Martin
2012-06-09 19:26 ` Simon Glass
2012-06-08 21:16 ` [U-Boot] [PATCH v3 14/14] tegra20: tec: add tegra20-common-post.h Allen Martin
2012-06-11 9:23 ` Thierry Reding
2012-06-09 5:30 ` [U-Boot] [PATCH v3 0/14] split tegra20 arm7 code into separate SPL Stephen Warren
2012-06-09 19:44 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611190524.GE6633@nvidia.com \
--to=amartin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox