[U-Boot] [PATCH v3 13/14] tegra20: plutux: change obj directory mkdir commands

Simon Glass
2012-06-09T19:26:27Z

Hi Allen,

On Fri, Jun 8, 2012 at 2:16 PM, Allen Martin <amartin@nvidia.com> wrote:

> Change the mkdir commands for the object directories to be more
> general purpose. This fixes an issue when building for SPL where
> SRCTREE and OBJTREE are the same, but $(obj) is under SPLTREE.
>
> Signed-off-by: Allen Martin <amartin@nvidia.com>
> ---
> board/avionic-design/plutux/Makefile | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/board/avionic-design/plutux/Makefile
> b/board/avionic-design/plutux/Makefile
> index d96d043..6bd394e 100644
> --- a/board/avionic-design/plutux/Makefile
> +++ b/board/avionic-design/plutux/Makefile
> @@ -25,8 +25,11 @@
>
> include $(TOPDIR)/config.mk
>
> -ifneq ($(OBJTREE),$(SRCTREE))
> -$(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
> +ifeq ($(wildcard $(obj)../common),)
> +$(shell mkdir -p $(obj)../common)
> +endif
> +ifeq ($(wildcard $(obj)../../nvidia/common),)
> +$(shell mkdir -p $(obj)../../nvidia/common)
> endif
>

Please could we have a little comment in the code here explaining what you
are doing? Could this go in a common include file perhaps? It feels like
this logic could in fact be done by spl/Makefile, but I haven't checked so
could be wrong.

> LIB = $(obj)lib$(BOARD).o
> --
> 1.7.9.5
>
> Regards,
Simon