[U-Boot] [PATCH v3 12/14] tegra20: Remove armv4t build flags

Simon Glass
2012-06-09T19:23:40Z

Hi Allen,

On Fri, Jun 8, 2012 at 2:16 PM, Allen Martin <amartin@nvidia.com> wrote:

> These flags were necessary when building tegra20 as a single binary
> that supported ARM7TDMI and Cortex A9. Now that the ARM7TDMI support
> is split into a separate SPL, this is no longer necessary.
>
> Signed-off-by: Allen Martin <amartin@nvidia.com>
> ---
> arch/arm/cpu/armv7/tegra20/config.mk | 12 ++----------
> arch/arm/cpu/tegra20-common/Makefile | 2 --
> 2 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/tegra20/config.mkb/arch/arm/cpu/armv7/tegra20/
> config.mk
> index 714daaf..e000a76 100644
> --- a/arch/arm/cpu/armv7/tegra20/config.mk
> +++ b/arch/arm/cpu/armv7/tegra20/config.mk
> @@ -23,16 +23,8 @@
> # Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> # MA 02111-1307 USA
> #
> -
> -# Tegra has an ARMv4T CPU which runs board_init_f(), so we must build
> these
> -# files with compatible flags
> -ifdef CONFIG_TEGRA20
> -CFLAGS_arch/arm/lib/board.o += -march=armv4t
> -CFLAGS_arch/arm/lib/memset.o += -march=armv4t
> -CFLAGS_lib/string.o += -march=armv4t
> -CFLAGS_common/cmd_nvedit.o += -march=armv4t
> -endif
> -
> +ifeq ($(CONFIG_SPL_BUILD),y)
> USE_PRIVATE_LIBGCC = yes
> +endif
>

Please can you add a little comment here about why you need this for SPL.

>
> CONFIG_ARCH_DEVICE_TREE := tegra20
> diff --git a/arch/arm/cpu/tegra20-common/Makefile
> b/arch/arm/cpu/tegra20-common/Makefile
> index 572538b..1978bc4 100644
> --- a/arch/arm/cpu/tegra20-common/Makefile
> +++ b/arch/arm/cpu/tegra20-common/Makefile
> @@ -27,8 +27,6 @@ include $(TOPDIR)/config.mk
>
> # The AVP is ARMv4T architecture so we must use special compiler
> # flags for any startup files it might use.
> -CFLAGS_arch/arm/cpu/tegra20-common/ap20.o += -march=armv4t
> -CFLAGS_arch/arm/cpu/tegra20-common/clock.o += -march=armv4t
> CFLAGS_arch/arm/cpu/tegra20-common/warmboot_avp.o += -march=armv4t
>
> LIB = $(obj)lib$(SOC)-common.o
> --
> 1.7.9.5
>
> Regards,
Simon