public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: Avoid writing to read-only bits in imximage.cfg
Date: Wed, 13 Jun 2012 14:27:15 +0200	[thread overview]
Message-ID: <201206131427.15674.marex@denx.de> (raw)
In-Reply-To: <4FD75739.90007@gmail.com>

Dear Vikram Narayanan,

> If in case this is valid according to the latest datasheet, ignore this
> patch.
> 
> --
> According to REV C manual, the register IOMUXC_IOMUXC_GPR4 has
> bits 4 and 5 read-only and the value is always set as zero.
> So write '0' to these bits instead of writing '1'.

I'm acking this as writing 0 to read-only bits is the only rightous thing to do. 
btw. how did you find this? Good catch, praise on you :-)

Acked-by: Marek Vasut <marex@denx.de>

> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Jason Liu <r64343@freescale.com>
> Cc: Dirk Behme <dirk.behme@googlemail.com>
> ---
>  board/freescale/mx6qarm2/imximage.cfg      |    2 +-
>  board/freescale/mx6qsabrelite/imximage.cfg |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/freescale/mx6qarm2/imximage.cfg
> b/board/freescale/mx6qarm2/imximage.cfg index ceecbf9..bf941a3 100644
> --- a/board/freescale/mx6qarm2/imximage.cfg
> +++ b/board/freescale/mx6qarm2/imximage.cfg
> @@ -167,7 +167,7 @@ DATA 4 0x020c407c 0x0F0000C3
>  DATA 4 0x020c4080 0x000003FF
> 
>  # enable AXI cache for VDOA/VPU/IPU
> -DATA 4 0x020e0010 0xF00000FF
> +DATA 4 0x020e0010 0xF00000CF
>  # set IPU AXI-id0 Qos=0xf(bypass) AXI-id1 Qos=0x7
>  DATA 4 0x020e0018 0x007F007F
>  DATA 4 0x020e001c 0x007F007F
> diff --git a/board/freescale/mx6qsabrelite/imximage.cfg
> b/board/freescale/mx6qsabrelite/imximage.cfg index c389427..62498ab 100644
> --- a/board/freescale/mx6qsabrelite/imximage.cfg
> +++ b/board/freescale/mx6qsabrelite/imximage.cfg
> @@ -164,7 +164,7 @@ DATA 4 0x020c407c 0x0F0000C3
>  DATA 4 0x020c4080 0x000003FF
> 
>  # enable AXI cache for VDOA/VPU/IPU
> -DATA 4 0x020e0010 0xF00000FF
> +DATA 4 0x020e0010 0xF00000CF
>  # set IPU AXI-id0 Qos=0xf(bypass) AXI-id1 Qos=0x7
>  DATA 4 0x020e0018 0x007F007F
>  DATA 4 0x020e001c 0x007F007F

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-06-13 12:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-12 14:50 [U-Boot] [PATCH] mx6: Avoid writing to read-only bits in imximage.cfg Vikram Narayanan
2012-06-12 15:05 ` Dirk Behme
2012-06-13  2:55   ` Liu Hui-R64343
2012-06-13 11:18     ` Marek Vasut
2012-06-13 11:28       ` Fabio Estevam
2012-06-13 11:31       ` Liu Hui-R64343
2012-06-13 12:24         ` Marek Vasut
2012-06-13 13:15           ` Liu Hui-R64343
2012-06-13 13:21             ` Marek Vasut
2012-06-13 12:27 ` Marek Vasut [this message]
2012-06-13 16:38   ` Vikram Narayanan
2012-06-13 17:15     ` Marek Vasut
2012-06-13 17:40       ` Vikram Narayanan
2012-06-15 14:27 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206131427.15674.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox