From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: Avoid writing to read-only bits in imximage.cfg
Date: Wed, 13 Jun 2012 15:21:30 +0200 [thread overview]
Message-ID: <201206131521.30514.marex@denx.de> (raw)
In-Reply-To: <AD13664F485EE54694E29A7F9D5BE1AF1F15D8@039-SN2MPN1-023.039d.mgd.msft.net>
Dear Liu Hui-R64343,
> Hi, Marek,
>
> >-----Original Message-----
> >From: Marek Vasut [mailto:marex at denx.de]
> >Sent: Wednesday, June 13, 2012 8:25 PM
> >To: u-boot at lists.denx.de
> >Cc: Liu Hui-R64343; Dirk Behme
> >Subject: Re: [U-Boot] [PATCH] mx6: Avoid writing to read-only bits in
> >imximage.cfg
> >
> >Dear Liu Hui-R64343,
> >
> >[...]
> >
> >> >> >> According to REV C manual, the register IOMUXC_IOMUXC_GPR4 has
> >> >> >> bits
> >> >> >> 4 and 5 read-only and the value is always set as zero.
> >> >> >> So write '0' to these bits instead of writing '1'.
> >> >> >
> >> >> >Jason, Fabio: What do you think? You should be the datasheet
> >> >> >'masters' ;)
> >> >>
> >> >> Yes, according to the RM,
> >> >> 5
> >> >> Reserved
> >> >> This read-only field is reserved and always has the value 0.
> >> >> 4
> >> >> Reserved
> >> >> This read-only field is reserved and always has the value 0.
> >> >>
> >> >> So, write 1 should have no effect.
> >> >
> >> >I really dislike how "write 1 should have no effect" sounds. Can you
> >> >please check with HW people?
> >>
> >> Since this is read-only bit, if you write 1 to it, it will have no
> >> effect.
> >
> >For how long do you work with hardware? Did it never occur to you that
> >when you wrote 1 to an "reserved" bit, it either did something you didn't
> >expect or you had to rework it later because the new CPU has that bit for
> >something else?
> >
> >> Yes, to avoid the confusion, for example to do the read-back check, I
> >> agree with not writing '1' to the read-only bit.
> >
> >Please, ask the hardware people about this.
>
> Yes, I will and back to you.
Thanks!
btw. sorry, I didn't meant to offend you.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-06-13 13:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:50 [U-Boot] [PATCH] mx6: Avoid writing to read-only bits in imximage.cfg Vikram Narayanan
2012-06-12 15:05 ` Dirk Behme
2012-06-13 2:55 ` Liu Hui-R64343
2012-06-13 11:18 ` Marek Vasut
2012-06-13 11:28 ` Fabio Estevam
2012-06-13 11:31 ` Liu Hui-R64343
2012-06-13 12:24 ` Marek Vasut
2012-06-13 13:15 ` Liu Hui-R64343
2012-06-13 13:21 ` Marek Vasut [this message]
2012-06-13 12:27 ` Marek Vasut
2012-06-13 16:38 ` Vikram Narayanan
2012-06-13 17:15 ` Marek Vasut
2012-06-13 17:40 ` Vikram Narayanan
2012-06-15 14:27 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206131521.30514.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox