From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] BOOT: Fix unused variable issue when enabling bootz support
Date: Wed, 13 Jun 2012 23:03:14 +0200 [thread overview]
Message-ID: <201206132303.14779.marex@denx.de> (raw)
In-Reply-To: <1339617312-7760-1-git-send-email-swarren@wwwdotorg.org>
Dear Stephen Warren,
> From: Stephen Warren <swarren@nvidia.com>
>
> cmd_bootm.c: In function 'do_bootz':
> cmd_bootm.c:1590:9: warning: variable 'iflag' set but not used
> [-Wunused-but-set-variable]
It can be applied directly too ...
Acked-by: Marek Vasut <marex@denx.de>
> Cc: Marek Vasut <marek.vasut@gmail.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> I think this is best taken through the Tegra tree, since it's needed to
> avoid introducing warnings when enabling CONFIG_CMD_BOOTZ, which the next
> patch enables, and we don't want MAKEALL -s tegra2 to suddenly start
> giving warnings.
> ---
> common/cmd_bootm.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index 5685232..45e726a 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1587,7 +1587,6 @@ static int bootz_start(cmd_tbl_t *cmdtp, int flag,
> int argc,
>
> static int do_bootz(cmd_tbl_t *cmdtp, int flag, int argc, char * const
> argv[]) {
> - ulong iflag;
> bootm_headers_t images;
>
> if (bootz_start(cmdtp, flag, argc, argv, &images))
> @@ -1598,7 +1597,7 @@ static int do_bootz(cmd_tbl_t *cmdtp, int flag, int
> argc, char * const argv[]) * overwrite all exception vector code, so we
> cannot easily
> * recover from any failures any more...
> */
> - iflag = disable_interrupts();
> + disable_interrupts();
>
> #if defined(CONFIG_CMD_USB)
> /*
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-06-13 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 19:55 [U-Boot] [PATCH 1/3] BOOT: Fix unused variable issue when enabling bootz support Stephen Warren
2012-06-13 19:55 ` [U-Boot] [PATCH 2/3] tegra: enable bootz command Stephen Warren
2012-06-13 19:55 ` [U-Boot] [PATCH 3/3] tegra: define fdt_load/fdt_high variables Stephen Warren
2012-06-13 21:03 ` Marek Vasut [this message]
2012-06-27 19:53 ` [U-Boot] [PATCH 1/3] BOOT: Fix unused variable issue when enabling bootz support Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201206132303.14779.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox