From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 17 Jun 2012 15:30:17 +0200 Subject: [U-Boot] [PATCH 1/3] imx: Use a clear identification of an unidentified CPU type In-Reply-To: References: <1339937889-15538-1-git-send-email-otavio@ossystems.com.br> Message-ID: <201206171530.17935.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Fabio Estevam, > On Sun, Jun 17, 2012 at 10:09 AM, Otavio Salvador > > wrote: > > On Sun, Jun 17, 2012 at 10:05 AM, Fabio Estevam wrote: > >>> default: > >>> - return "unknown"; > >>> + return ""; > >> > >> I really don't see any improvement here. > > > > It is just to avoid a i.MXunkown return; besides this is how I am > > doing in the mx23 code too. > > This is OK. If you read "i.MXunkown" things are too broken already > because the chip version could not be read. > > Reading "i.MX" will make things no better. This was from my head actually ... and I think this is better. The text is at least not mangled so badly. So let's keep it. Best regards, Marek Vasut