From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 17 Jun 2012 20:41:49 +0200 Subject: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo() In-Reply-To: References: <1339937889-15538-1-git-send-email-otavio@ossystems.com.br> <4FDE1A40.40008@denx.de> Message-ID: <201206172041.49705.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > On Sun, Jun 17, 2012 at 2:56 PM, Stefano Babic wrote: > >> Correct, but isn't the return value mangled somehow (like having major > >> rev. << 16 and minor rev. << 0 )? Or that's only IMX? > > > > Checking in current implementations for get_cpu_rev() (i.MX / OMAP24 / > > OMAP3 / AM33, and even board/apollon/sys_info.c: I do not know why the > > cpu detection is inseide this file), none of them requires strictly 32 > > bit. However, we should be coherent in all code - for this reason I > > dislike if one of the i.MX is implemented differently as for other SOCs. > > So, we change this one to follow the others or fix the others? Fix the others ;-) Best regards, Marek Vasut